----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33221/#review80524 -----------------------------------------------------------
Ship it! Please do the minor variable renames before checking in. core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java <https://reviews.apache.org/r/33221/#comment130501> Can you rename loadOnTask to loadDefaultResources and ACTION_CONFS_LOAD to ACTION_CONFS_LOAD_DEFAULT_RESOURCES? core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java <https://reviews.apache.org/r/33221/#comment130500> Can you rename loadOnTask to loadDefaultResources and ACTION_CONFS_LOAD to ACTION_CONFS_LOAD_DEFAULT_RESOURCES? - Rohini Palaniswamy On April 17, 2015, 5:56 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33221/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 5:56 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2205 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > dbb50ba > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > cf22ed6 > core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 4d6a1b4 > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 18de48a > core/src/main/resources/oozie-default.xml 3936fca > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > c28839c > > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 039bd84 > > Diff: https://reviews.apache.org/r/33221/diff/ > > > Testing > ------- > > tested on real cluster. > > > Thanks, > > Ryota Egashira > >
