> On April 17, 2015, 5:47 p.m., Robert Kanter wrote:
> > client/src/main/java/org/apache/oozie/client/OozieClient.java, line 2042
> > <https://reviews.apache.org/r/33108/diff/2/?file=930406#file930406line2042>
> >
> > I think we should make this
> > if (file.startsWith("/") || file.startsWith("file://"))
> > Otherwise, what happens when someone tries S3 or some other FileSystem?
For the relative path, I revised this.
It works to:
oozie validate myapp/workflow.xml
oozie validate /home/oozie/myapp/workflow.xml
oozie validate file:///home/oozie/myapp/workflow.xml
String fileName = file;
if (file.startsWith("file://")) {
fileName = file.substring(7, file.length());
}
if (!fileName.contains("://")) {
......
fileName = f.getAbsolutePath();
}
> On April 17, 2015, 5:47 p.m., Robert Kanter wrote:
> > client/src/main/java/org/apache/oozie/cli/OozieCLI.java, line 2022
> > <https://reviews.apache.org/r/33108/diff/2/?file=930405#file930405line2022>
> >
> > Given that we're keeping this for compatibility, I think we should keep
> > the Unit Test for it.
Keep the TestValidation.
> On April 17, 2015, 5:47 p.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java, line 132
> > <https://reviews.apache.org/r/33108/diff/2/?file=930410#file930410line132>
> >
> > What does this do? Can you add a comment explaining this?
This is to check the root element declaration(workflow-app, coordinator-app,
bundle-app).
If invalid, move to next schema validation.
- Azrael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33108/#review80482
-----------------------------------------------------------
On April 15, 2015, 3:13 p.m., Azrael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33108/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 3:13 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2159
> https://issues.apache.org/jira/browse/OOZIE-2159
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Move 'oozie validate' to server-side.
> It can validate both local file and hdfs file.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java aa7ad6c
> client/src/main/java/org/apache/oozie/client/OozieClient.java db21e9e
> client/src/main/java/org/apache/oozie/client/rest/JsonTags.java ab6699f
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java
> 2434b19
> client/src/test/java/org/apache/oozie/cli/TestValidation.java 76c1445
> core/src/main/java/org/apache/oozie/servlet/V2ValidateServlet.java
> PRE-CREATION
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e56b679
> core/src/test/java/org/apache/oozie/servlet/TestV2ValidateServlet.java
> PRE-CREATION
> docs/src/site/twiki/DG_CommandLineTool.twiki 9494b22
> webapp/src/main/webapp/WEB-INF/web.xml d865d23
>
> Diff: https://reviews.apache.org/r/33108/diff/
>
>
> Testing
> -------
>
> Unit test.
> Manual test.
>
>
> Thanks,
>
> Azrael Park
>
>
