----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33400/#review81348 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java <https://reviews.apache.org/r/33400/#comment131694> Please get rid of this check. You have already done the globbing. To throw an error after that is meaningless. NN and DistributedFileSystem are already built to handle this by fetching in batches. Need to remove this check everywhere - https://issues.apache.org/jira/browse/OOZIE-1682 . core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java <https://reviews.apache.org/r/33400/#comment131720> Redundant code. If globbing returns a list of paths, then it means something exists. All you need is FileStatus[] fileStatuses = fs.globStatus(path); return (fileStatuses != null and fileStatuses.length > 0); docs/src/site/twiki/WorkflowFunctionalSpec.twiki <https://reviews.apache.org/r/33400/#comment131721> Only need below in documentation It returns =true= or =false= depending if the specified path URI exists or not. If the URI is a glob pattern, it returns true if there is atleast one matching path. - Rohini Palaniswamy On April 21, 2015, 5:17 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33400/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 5:17 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2215 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java > f8af61c > core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java > c81fc61 > docs/src/site/twiki/WorkflowFunctionalSpec.twiki e3790a4 > > Diff: https://reviews.apache.org/r/33400/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
