> On April 28, 2015, 9:13 p.m., Robert Kanter wrote: > > core/src/main/conf/oozie-log4j.properties, line 40 > > <https://reviews.apache.org/r/33624/diff/1/?file=943971#file943971line40> > > > > Why are we changing the log4j config here? > > Shwetha GS wrote: > Not required for this patch. I had plans of doing this in another jira > which I never did. Added this during testing, so came in the patch. If you > have concerns about adding in this patch, I can revert
Ya, let's do this as it's own patch. I know it's a minor change, but logging changes can sometimes have a big impact on external tools, so it would be good to separate that from this important bug fix. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33624/#review81883 ----------------------------------------------------------- On April 28, 2015, 11:16 a.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33624/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 11:16 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1993 > https://issues.apache.org/jira/browse/OOZIE-1993 > > > Repository: oozie-git > > > Description > ------- > > The issue was with picking up new execution path during re-runs. This will > also address the issue in OOZIE-1879. > Changes: > 1. SignalXCommand to pick up the new execution path > 2. Removed actionEndTimes comparison > 3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes > > > Diffs > ----- > > core/src/main/conf/oozie-log4j.properties 2b20ff2 > core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158 > core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278 > core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 0e99ae2 > core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java > d661d08 > core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1 > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java > 919c95a > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java > 706cc2a > > Diff: https://reviews.apache.org/r/33624/diff/ > > > Testing > ------- > > end to end test for the example workflow in the jira - with failures at > different nodes > > > Thanks, > > Shwetha GS > >
