----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33639/#review83276 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java <https://reviews.apache.org/r/33639/#comment134179> This code needs to be called in ActionCheckXCommand as well if the launcher job status is killed. core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java <https://reviews.apache.org/r/33639/#comment134177> The information from the sequence file needs to be updated into the database. core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java <https://reviews.apache.org/r/33639/#comment134176> Have the whole code inside the loop in a try catch block, log the exception and continue. If it is already killed or succeeded, killjob() will throw an exception core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java <https://reviews.apache.org/r/33639/#comment134232> Remove this line core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java <https://reviews.apache.org/r/33639/#comment134233> Remove this try catch block. catch block is unnecessary - Rohini Palaniswamy On April 28, 2015, 8:26 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33639/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 8:26 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2219 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > eb2dbdb > core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 8b2dc16 > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java > 72f0114 > > Diff: https://reviews.apache.org/r/33639/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
