> On May 7, 2015, 5:59 p.m., Rohini Palaniswamy wrote: > > hadooplibs/hadoop-auth-1/pom.xml, line 47 > > <https://reviews.apache.org/r/33948/diff/1/?file=952396#file952396line47> > > > > Check if you can have a jar.classifier property which defaults to "" > > specified in parent pom.xml and its maven-jar-plugin definition and just > > override that property value to hadooplib.classifier here so that you don't > > have to define the whole plugin section everytime?
I tried this, but when maven-jar-pluging with execution definition is placed on top-level pom, oozie-client, oozie-core and other modules also creates jar file with classifier(oozie-core-hadoop1.jar etc) exclusion is only applied for goal/phase, and to exclude particular modules(oozie-core, oozie-client, others) not to use classifier, need to add do-nothing definition in these modules pom. http://stackoverflow.com/questions/7800647/in-a-maven-multi-module-project-how-can-i-disable-a-plugin-in-one-child so i rather chose to change hadooplibs related poms only as currently done, than editing other modules pom. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33948/#review82856 ----------------------------------------------------------- On May 14, 2015, 5:01 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33948/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 5:01 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > WIP, still rough and not fully functional, sharing for early review. > > mvn compile works for hadoop-1, hadoop-2, hadoop-0.23 > mvn package works for hadoop-1, but not for hadoop-2 and 23. > > also org.apache.maven.plugins definition added to all version of poms > repeatedly, wonder how to remove redundancy, but without this doens't work > > > Diffs > ----- > > client/pom.xml 73f7ef5 > core/pom.xml c62556c > hadooplibs/hadoop-auth-0.23/pom.xml 5769f66 > hadooplibs/hadoop-auth-1/pom.xml ac36798 > hadooplibs/hadoop-auth-2/pom.xml 977d49c > hadooplibs/hadoop-distcp-0.23/pom.xml c13b78d > hadooplibs/hadoop-distcp-1/pom.xml 5b4f96f > hadooplibs/hadoop-distcp-2/pom.xml 4097cc4 > hadooplibs/hadoop-distcp-3/pom.xml 8d8180d > hadooplibs/hadoop-utils-0.23/pom.xml 1bd243e > hadooplibs/hadoop-utils-1/pom.xml 48d97b0 > hadooplibs/hadoop-utils-2/pom.xml 832cf5b > hadooplibs/hadoop-utils-3/pom.xml e7df53b > pom.xml ea9ccef > sharelib/distcp/pom.xml a329b7b > sharelib/hive/pom.xml 3da0bdc > sharelib/hive2/pom.xml 41eade9 > sharelib/oozie/pom.xml 484fb45 > sharelib/pig/pom.xml fd3cd66 > sharelib/sqoop/pom.xml 5308bd5 > > Diff: https://reviews.apache.org/r/33948/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
