[
https://issues.apache.org/jira/browse/OOZIE-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583893#comment-14583893
]
Rohini Palaniswamy commented on OOZIE-2178:
-------------------------------------------
Looks like a lot of grunt work. Thanks a lot for getting this done Robert. Just
had few minor comments.
- It would be better to rename the method arguments instead of the javadoc for
below changes
{code}
- * @param pending set pending value
+ * @param i set pending value
--- core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java
+++ core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java
- * @param dataInName
+ * @param dataName
- * @param dataInName
+ * @param dataName
- * @param dataOutName
+ * @param dataName
- * @param dataInName
+ * @param dataName
- * @param dataOutName
+ * @param dataName
{code}
- Below change does not look right.
{code}
- * The "rerunType" can be set as {@link RestConstants.JOB_COORD_RERUN_DATE} or
- * {@link RestConstants.JOB_COORD_RERUN_ACTION}.
+ * The "rerunType" can be set as {@link
RestConstants#JOB_COORD_RERUN_FAILED_PARAM} or
+ * {@link RestConstants#JOB_COORD_RERUN_NOCLEANUP_PARAM}.
{code}
> fix javadoc to compile on JDK8
> ------------------------------
>
> Key: OOZIE-2178
> URL: https://issues.apache.org/jira/browse/OOZIE-2178
> Project: Oozie
> Issue Type: Bug
> Reporter: Ryota Egashira
> Assignee: Robert Kanter
> Attachments: OOZIE-2178.patch
>
>
> creating this JIRA from discussion on OOZIE-2177
> JDK8 enforce strict HTML4 checking on javadoc.
> when compiling oozie on JDK8, hit following javadoc error
> {quote}
> [ERROR]
> /Users/egashira/Projects/git/aoozie-cms/client/src/main/java/org/apache/oozie/cli/OozieCLI.java:205:
> error: self-closing element not allowed
> [ERROR] * <p/>
> {quote}
> the fix is to change self-closing element <p/>, <br/> to <p></p>, <br></br>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
