----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35472/#review90339 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java (line 106) <https://reviews.apache.org/r/35472/#comment143355> The for loop will be useless if tableProblem value is true. So tableProblem should be outside of forloop and gaurded by it. core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java (line 149) <https://reviews.apache.org/r/35472/#comment143350> Are you facing any issue when you pass schema information for other db servers? core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java (line 163) <https://reviews.apache.org/r/35472/#comment143352> you can combine the else if statement core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java (line 205) <https://reviews.apache.org/r/35472/#comment143358> column definition mismatch will not create any problem. core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java (line 239) <https://reviews.apache.org/r/35472/#comment143357> problem = true missing here - Jaydeep Vishwakarma On June 15, 2015, 9:03 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35472/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 9:03 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2245 > https://issues.apache.org/jira/browse/OOZIE-2245 > > > Repository: oozie-git > > > Description > ------- > > See > https://issues.apache.org/jira/browse/OOZIE-2245?focusedCommentId=14555005&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14555005 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/SchemaCheckXCommand.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/SchemaCheckerService.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 8960073 > > Diff: https://reviews.apache.org/r/35472/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
