-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23301/
-----------------------------------------------------------
(Updated July 6, 2015, 3:36 a.m.)
Review request for oozie.
Changes
-------
Addressed comments.
Rebased on the lates branch.
Bugs: OOZIE-1918
https://issues.apache.org/jira/browse/OOZIE-1918
Repository: oozie-git
Description
-------
Subclasses of ActionXCommand have some duplicated code. Refactoring make it
more neat.
This patch contain:
* Renaming CompletedActionXCommand to ActionCompletedXCommand and extending
ActionXCommand
* Moving some variables and methods to ActionXCommand and making it protected
* More meaningful log message : On exeucte(), actionId is duplicated so removed
* Adding handleExecutionFail() to handle ActionExcutionException during
execute()
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/DagEngine.java 9061d17
core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
5827387
core/src/main/java/org/apache/oozie/command/wf/ActionCompletedXCommand.java
PRE-CREATION
core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 4006441
core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java
33498bf
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
e06649c
core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 2616d32
core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java
bc39bce
core/src/test/java/org/apache/oozie/ForTestingActionExecutor.java a70dc02
core/src/test/java/org/apache/oozie/command/wf/TestCompletedActionXCommand.java
a4f0e83
core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 14f5294
Diff: https://reviews.apache.org/r/23301/diff/
Testing
-------
No added new testcase.
Done manual test.
Thanks,
Azrael Seoeun Park
