----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36123/#review91593 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java (line 57) <https://reviews.apache.org/r/36123/#comment145055> rename to CALLBACK_ACTION_TIMEOUT_MS and also rename the conf value to include ms core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java (line 121) <https://reviews.apache.org/r/36123/#comment145053> == can be used for enum comparisons core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java (line 193) <https://reviews.apache.org/r/36123/#comment145054> There can be other params present here. Check for 2 elements may not be appropriate docs/src/site/twiki/DG_CallbackActionExtension.twiki (line 56) <https://reviews.apache.org/r/36123/#comment145057> reword docs/src/site/twiki/DG_CallbackActionExtension.twiki (line 84) <https://reviews.apache.org/r/36123/#comment145058> overwritten - Srikanth Sundarrajan On July 9, 2015, 11:51 a.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36123/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 11:51 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2259 > https://issues.apache.org/jira/browse/OOZIE-2259 > > > Repository: oozie-git > > > Description > ------- > > Adding callback as an action, It have support for HTTP and JMS server. Not > covering Excecutor level queue, I will create a separate jira for it. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java c381432 > client/src/main/resources/callback-action-0.1.xsd PRE-CREATION > > core/src/main/java/org/apache/oozie/action/callback/CallBackActionExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/callback/JMSNotification.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/CallBackActionService.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 4dc127e > > core/src/test/java/org/apache/oozie/action/callback/TestCallBackActionExecutor.java > PRE-CREATION > docs/src/site/twiki/DG_CallbackActionExtension.twiki PRE-CREATION > docs/src/site/twiki/DG_CommandLineTool.twiki 9494b22 > docs/src/site/twiki/index.twiki 8591530 > > Diff: https://reviews.apache.org/r/36123/diff/ > > > Testing > ------- > > Done, > Will add more test cases. > > > Thanks, > > Jaydeep Vishwakarma > >
