> On June 15, 2015, 5:18 p.m., Robert Kanter wrote: > > core/pom.xml, line 41 > > <https://reviews.apache.org/r/34854/diff/11/?file=984678#file984678line41> > > > > Versions should go in the root pom. > > > > Also, io.dropwizard.metrics are the same thing as com.codahale.metrics > > (presumably newer because the latest version is higher and it's now what's > > mentioned on their website). We already have some dependencides on the > > latter, and it would be good to keep this all consistent. Can you replace > > the existing com.codahale.metrics dependencies with io.dropwizard.metrics? > > > > And given that we'll have a bunch of these dependencies, it's probably > > a good idea to create a variable for the version (like we do with some > > others such as tomcat). For example, "dropwizard.metrics.version" or > > something. > > Narayan Periwal wrote: > When I am replacing the existing com.codahale.metrics dependencies with > io.dropwizard.metrics, it looks like some methods are not backward compatible > with some classes. > I get the following error on server startup : > java.lang.NoSuchMethodError: > com.fasterxml.jackson.core.JsonFactory.requiresPropertyOrdering()Z > So I am keeping the existing com.codahale.metrics as it is. > > Robert Kanter wrote: > Are you sure? I tried applying your latest patch and then modified the > root and core poms slightly and it worked for me. As for jackson, Oozie > pulls in jackson 1.8.8 while dropwizard pulls in 2.4.2, but that's okay > because they have different package names, so there's no conflict. Did you > perhaps exclude jackson from dropwizard when you tried it? > > Can you try again? > And for organization, it would also be good to move the new dropwizard > dependencies near the existing ones in ooze-core's pom. > > > Here's what I did: > diff --git a/core/pom.xml b/core/pom.xml > index 1cda6f0..e48d25f 100644 > --- a/core/pom.xml > +++ b/core/pom.xml > @@ -349,19 +349,13 @@ > </dependency> > > <dependency> > - <groupId>com.codahale.metrics</groupId> > - <artifactId>metrics-core</artifactId> > - <scope>compile</scope> > - </dependency> > - > - <dependency> > - <groupId>com.codahale.metrics</groupId> > + <groupId>io.dropwizard.metrics</groupId> > <artifactId>metrics-jvm</artifactId> > <scope>compile</scope> > </dependency> > > <dependency> > - <groupId>com.codahale.metrics</groupId> > + <groupId>io.dropwizard.metrics</groupId> > <artifactId>metrics-json</artifactId> > <scope>compile</scope> > </dependency> > diff --git a/pom.xml b/pom.xml > index 752df88..e9d46d5 100644 > --- a/pom.xml > +++ b/pom.xml > @@ -1402,21 +1402,15 @@ > </dependency> > > <dependency> > - <groupId>com.codahale.metrics</groupId> > - <artifactId>metrics-core</artifactId> > - <version>3.0.2</version> > - </dependency> > - > - <dependency> > - <groupId>com.codahale.metrics</groupId> > + <groupId>io.dropwizard.metrics</groupId> > <artifactId>metrics-jvm</artifactId> > - <version>3.0.2</version> > + <version>${dropwizard.metrics.version}</version> > </dependency> > > <dependency> > - <groupId>com.codahale.metrics</groupId> > + <groupId>io.dropwizard.metrics</groupId> > <artifactId>metrics-json</artifactId> > - <version>3.0.2</version> > + <version>${dropwizard.metrics.version}</version> > </dependency> > > <!-- For drawing runtime DAG --> > > Robert Kanter wrote: > If that somehow doesn't work, then I'd rather us just use codahale 3.0.2 > for all of these. It's better to not mix the dependencies; while they have > different groupId's, they do have the same package names internally, so it > could cause some problem later on if we mix them.
I tried excluding jackson from dropwizard, but then the "mvn clean install" fails as MetricsInstrumentation.java has dependency on com.fasterxml.jackson.core.JsonProcessingException; com.fasterxml.jackson.databind.ObjectMapper; So, I have just used codahale 3.0.2 for all, thus replacing the dropwizrd dependencies. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34854/#review87934 ----------------------------------------------------------- On July 14, 2015, 8:47 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34854/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 8:47 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2251 > https://issues.apache.org/jira/browse/OOZIE-2251 > > > Repository: oozie-git > > > Description > ------- > > We have been logging so many important matrices in oozie-instrumentation.log > . These information is very useful for oozie functional monitoring. But it is > always difficult to get the meaning from flat file. If we expose this > information on some graphing tool, We can get the lot of meaning out of it > and can take some actions based on it. > > > Diffs > ----- > > core/pom.xml 7877773 > > core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java > 2a00a73 > core/src/main/java/org/apache/oozie/util/Instrumentation.java 4eb6386 > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > 185b67e > core/src/main/resources/oozie-default.xml 4dc127e > docs/src/site/twiki/AG_Install.twiki 0ce2609 > pom.xml 4dc79c3 > webapp/pom.xml e42e219 > > Diff: https://reviews.apache.org/r/34854/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
