[ 
https://issues.apache.org/jira/browse/OOZIE-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635827#comment-14635827
 ] 

Robert Kanter commented on OOZIE-2245:
--------------------------------------

The ". -1 the patch seems to change 1 line(s) with JPA 
Entity/Colum/Basic/Lob/Transient annotations" is due to a comment that has the 
word "@Column" in it and is not a real problem:
{noformat}
+                    // Some Id fields don't have an @Column annotation
{noformat}

It also did compile and ran all of the unit tests with no failures; not sure 
why it said it couldn't.
https://builds.apache.org/job/oozie-trunk-precommit-build/2446/testReport/

> Service to periodically check database schema
> ---------------------------------------------
>
>                 Key: OOZIE-2245
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2245
>             Project: Oozie
>          Issue Type: New Feature
>          Components: core
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-2245.002.patch, OOZIE-2245.patch
>
>
> We've seen a number of issues related to the database schema being incorrect 
> (more than you would think).  It seems some users go and muck around in the 
> Oozie database, adding/removing columns and indexes, changing the default 
> value of columns, etc.  The issues caused by this can be very difficult to 
> track down because their cause is not obvious and we generally assume the 
> database schema is correct.  For example, we saw an issue where Oozie was 
> taking a long time to create Coordinator actions, and it turned out that the 
> cause was that some indexes were missing, which made the Purge queries slow, 
> which slowed down the whole database whenever the PurgeService ran.  Another 
> example was that the pause time was automatically being set whenever a 
> Coordinator job was submitted, because the default value for the column was 
> incorrect.
> We should create a Service which periodically runs and checks that the schema 
> is correct.  It can output details about what's wrong to the log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to