[ 
https://issues.apache.org/jira/browse/OOZIE-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697707#comment-14697707
 ] 

Rohini Palaniswamy commented on OOZIE-2329:
-------------------------------------------

bq. -1 TESTS - patch does not compile, cannot run testcases
  Can you check?

Just one minor comment. Move System.out.println("tag id : " + tag); after the 
if block, else it is going to print tag id : null, everytime when yarn restart 
handling  is disabled.
{code}
+        System.out.println("tag id : " + tag);
+        if (tag == null) {
+            System.out.print("Could not find Yarn tags property " + 
CHILD_MAPREDUCE_JOB_TAGS);
+            return childYarnJobs;
+        }
{code}

> Make handling yarn restarts configurable
> ----------------------------------------
>
>                 Key: OOZIE-2329
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2329
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Purshotam Shah
>            Assignee: Purshotam Shah
>         Attachments: OOZIE-2329-V1.patch, OOZIE-2329-V2.patch, 
> OOZIE-2329-V3.patch
>
>
>   For a cluster with lot of RUNNING jobs, this overwhelms RM causing lot of 
> blocked threads as it does ACL check on each application before applying the 
> filter tag and that is inside a synchronized block.  Hadoop team is looking 
> at doing the filtering first outside synchronized block to limit the number 
> of applications for which ACL check needs to be done reducing time spent in 
> synchronized block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to