-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37906/#review97303
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java (line 
355)
<https://reviews.apache.org/r/37906/#comment153145>

    Can be reverted. This is not required as ActionEndXCommand is called from 
ActionStartXCommand only for control nodes like start, decision, fork and join. 
It can be enhanced to do for fs actions. For all others, ActionEndXCommand will 
be called by ActionCheckXCommand.


- Rohini Palaniswamy


On Sept. 1, 2015, 4:46 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37906/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 4:46 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-2345
>     https://issues.apache.org/jira/browse/OOZIE-2345
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> We have few customers whose SLA is 8 min. They have around 30 actions. There 
> are 25 actions in fork.
> Though forked action jobs runs concurrently. forked action job submission is 
> sequential.
> Whenever NN is slow, job submission takes more time. Even if job submission 
> is delay for 30 sec. Total WF delay will be ~12 min.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> e06649cf9bbc7c0997e1d4f94fa7e695533f8343 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 
> 2616d322ea0dd85942fcb33c73d7d33af049b789 
>   
> core/src/main/java/org/apache/oozie/command/wf/ForkedActionStartXCommand.java 
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 
> d1fcd1ac933aaeaea22cdd3fcbe55be386281fbb 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java 
> 830a58ebe152baed0a922e78855be51d3bf1b21c 
>   core/src/main/resources/oozie-default.xml 
> 32a1df044b9910ba9cfade88005a598e0ab3a7b3 
>   
> core/src/test/java/org/apache/oozie/command/wf/TestForkedActionStartXCommand.java
>  e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 
> 02f61668e6d6d03674f5d516853057fb94fed518 
>   core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java 
> 4268b301d3efff05e870b3d833ba5fd5b9cc0d5a 
> 
> Diff: https://reviews.apache.org/r/37906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Reply via email to