----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33207/#review100532 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java (line 159) <https://reviews.apache.org/r/33207/#comment157753> This seems like a util function access across classes. Can this be in an appropriate util class (LauncherMapperHelper) where the tag is originally formed ? core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java (line 252) <https://reviews.apache.org/r/33207/#comment157755> An important function is tucked in another statement. Avoid to help improve code readability. Would prefer that getActionYarnTag is in an independent statement assigned to a var and used subsequently. hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java (line 59) <https://reviews.apache.org/r/33207/#comment157756> Shouldn't this be the other way around. why are we prefering System::getProperty() over actionConf ? - Srikanth Sundarrajan On Sept. 22, 2015, 11:01 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33207/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 11:01 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2243 > https://issues.apache.org/jira/browse/OOZIE-2243 > > > Repository: oozie-git > > > Description > ------- > > Whenever the coord action or workflow gets killed only the job that has error > gets killed while the other hadoop jobs keeps on running and only the > workflow status gets changed to killed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > a6e7000 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > e22329d > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 85a6cd7 > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java > e493d4d > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > ce8c14f > > Diff: https://reviews.apache.org/r/33207/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
