----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39083/#review103381 -----------------------------------------------------------
Mostly good. Just few minor comments. core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java (line 393) <https://reviews.apache.org/r/39083/#comment161400> UserGroupInformationService.getProxyUser() core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java (line 401) <https://reviews.apache.org/r/39083/#comment161402> Can you change error message to Could not move path [{0}] to trash on delete It does not sound grammatically right to read though it conveys the message. I see that the text is copied from the other error message. Can you also just change that to Could not delete path [{0}] docs/src/site/twiki/WorkflowFunctionalSpec.twiki (line 2873) <https://reviews.apache.org/r/39083/#comment161403> xs:boolean docs/src/site/twiki/WorkflowFunctionalSpec.twiki (line 4342) <https://reviews.apache.org/r/39083/#comment161404> This is schema version 0.2. Do not change here. - Rohini Palaniswamy On Oct. 7, 2015, 12:49 p.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39083/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 12:49 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2367 > https://issues.apache.org/jira/browse/OOZIE-2367 > > > Repository: oozie-git > > > Description > ------- > > providing skip trash option on fs delete, setting skip-trash to 'false' in fs > delete will move targeted directory to user's trash direcotry. > > > Diffs > ----- > > client/src/main/resources/oozie-workflow-0.5.xsd b01580c > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 8d96a47 > core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java > 86d5fa9 > docs/src/site/twiki/WorkflowFunctionalSpec.twiki bf4d123 > > Diff: https://reviews.apache.org/r/39083/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Jaydeep Vishwakarma > >
