----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41623/#review112195 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/ZKLocksService.java (line 200) <https://reviews.apache.org/r/41623/#comment172521> The null check should be here instead of isLockHeld. InterProcessReadWriteLock readWriteLock = zkLocks.get(resource); //It should never be null, but just in case if (readWriteLock != null) { if (!isLockHeld(readWriteLock)) { .... } } - Rohini Palaniswamy On Dec. 29, 2015, 12:31 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41623/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 12:31 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1922 > https://issues.apache.org/jira/browse/OOZIE-1922 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1922 - MemoryLocksService fails if lock is acquired multiple times in > same thread and released > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/lock/MemoryLocks.java > ee564b3def2ce42b06f697c3384b1e102ac6a3ba > core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > e3eccdb3f95e74198c3d42d19022b4acfc3d18e5 > core/src/main/java/org/apache/oozie/service/ZKLocksService.java > e3a6bcf04048e140d2ced9d8bdbfe08b01b323e4 > core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java > 0efe31033f63055c08e42202c56c336248271afe > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > 02cc1372dc015713f0bb1f6861b7e4b7455c4f13 > > Diff: https://reviews.apache.org/r/41623/diff/ > > > Testing > ------- > > TestZKLocksService.testReentrantMultipleCall already has reentrant test cases. > > > Thanks, > > Purshotam Shah > >
