[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152380#comment-15152380
]
Ferenc Denes commented on OOZIE-2429:
-------------------------------------
[~puru] Thank for the review. I have spent some more time walking through the
precondition verification code, and this as well. I think this solution is more
correct fot he following reasons:
The veryfyPrecondition throws an exception in case of a precondition issue.
However this check above is to skip some actions and become a no operation with
no additional external effect.
Throwing an exception in this case would alter the behaviour of the
verification, and probably the intent of that as well.
Also this status change is up to the logic above this condition check. The
code/condition mentioned here is for the administration of the changed action
(like updating the modification time, SLAs, DB etc).
Can you please see the full execute() function to see if this check is in the
right place.
Thanks a lot
> TestEventGeneration test is flakey
> ----------------------------------
>
> Key: OOZIE-2429
> URL: https://issues.apache.org/jira/browse/OOZIE-2429
> Project: Oozie
> Issue Type: Bug
> Components: action, tests
> Affects Versions: trunk
> Reporter: Ferenc Denes
> Assignee: Ferenc Denes
> Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2429-1.patch, OOZIE-2429-2.patch
>
>
> TestEventGeneration's testForNoDuplicates fails tome to time depending on the
> circumstances of the test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
