[ 
https://issues.apache.org/jira/browse/OOZIE-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155286#comment-15155286
 ] 

Hadoop QA commented on OOZIE-2283:
----------------------------------

Testing JIRA OOZIE-2283

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:red}-1{color} the patch contains 1 line(s) with trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1762
.    Tests failed: 5
.    Tests errors: 0

.    The patch failed the following testcases:

.      testSamplers(org.apache.oozie.util.TestMetricsInstrumentation)
.      
testNone(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)
.      testForNoDuplicates(org.apache.oozie.event.TestEventGeneration)
.      
testActionKillCommandActionNumbers(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)
.      
testCoordStatus_Killed(org.apache.oozie.command.coord.TestCoordChangeXCommand)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/2751/

> Documentation should not say that System.exit is not allowed in Java Action
> ---------------------------------------------------------------------------
>
>                 Key: OOZIE-2283
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2283
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: docs
>    Affects Versions: 3.3.2
>            Reporter: Robert Kanter
>            Assignee: Eva Andreasson
>             Fix For: trunk
>
>         Attachments: OOZIE-2283-002.patch, OOZIE-2283.001.patch
>
>
> The Java Action docs say:
> {quote}
> The main Java class must not call System.exit(int n) as this will make the 
> java action to do an error transition regardless of the used exit code.
> {quote}
> http://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a3.2.7_Java_Action
> This has not been true for quite some time.  Oozie counts {{System.exit(0)}} 
> as OK and non-zero values as the ERROR transition.
> https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java#L259



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to