[
https://issues.apache.org/jira/browse/OOZIE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156771#comment-15156771
]
Hadoop QA commented on OOZIE-2462:
----------------------------------
Testing JIRA OOZIE-2462
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1762
. Tests failed: 2
. Tests errors: 0
. The patch failed the following testcases:
. testForNoDuplicates(org.apache.oozie.event.TestEventGeneration)
. testSamplers(org.apache.oozie.util.TestMetricsInstrumentation)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/2754/
> When calling ParamChecker.notNull() in CoordActionsIgnoreXCommand.java,
> "Action" should be passed instead of "Action cannot be null".
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-2462
> URL: https://issues.apache.org/jira/browse/OOZIE-2462
> Project: Oozie
> Issue Type: Bug
> Reporter: Manjunath Ballur
> Priority: Trivial
> Labels: newbie
> Attachments: OOZIE-2462-001.patch, OOZIE-2462-002.patch
>
>
> In ParamChecker::notNull() method, if the passed object is null, then
> following exception is thrown:
> if (obj == null) {
> throw new IllegalArgumentException(name + " cannot be null");
> }
> Here, "name" is the name of the object being checked.
> In "CoordActionsIgnoreXCommand::checkAllActionsStatus()" method, following
> piece of code calls "ParamChecker::notNull()" method:
> ParamChecker.notNull(action, "Action cannot be null");
> The above statement should be changed to:
> ParamChecker.notNull(action, "Action");
> With the current code, when "action" is null, then the message printed will
> be:
> "Action cannot be null cannot be null"
> "cannot be null" is printed twice.
> Hence, we need to remove "cannot be null" while calling
> "ParamChecker::notNull()" method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
