----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43970/#review120792 -----------------------------------------------------------
I need to spend more time (hopefully sometime next week) looking through the more complicated logic changes with LogLine in more detail, but here's some trivial stuff I found during a first pass. core/src/main/java/org/apache/oozie/util/LogLine.java (line 33) <https://reviews.apache.org/r/43970/#comment182281> Boolean to indicate if line was split successfully. core/src/main/java/org/apache/oozie/util/LogLine.java (line 35) <https://reviews.apache.org/r/43970/#comment182282> isSplit core/src/main/java/org/apache/oozie/util/LogLine.java (line 53) <https://reviews.apache.org/r/43970/#comment182283> isSplit core/src/main/java/org/apache/oozie/util/LogLine.java (line 57) <https://reviews.apache.org/r/43970/#comment182284> setSplit(boolean isSplit) core/src/main/java/org/apache/oozie/util/LogLine.java (line 58) <https://reviews.apache.org/r/43970/#comment182285> this.isSplit = isSplit core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java (line 42) <https://reviews.apache.org/r/43970/#comment182288> Is this method used anymore? core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java (line 62) <https://reviews.apache.org/r/43970/#comment182286> Whitespace core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java (line 212) <https://reviews.apache.org/r/43970/#comment182291> whitespace core/src/main/java/org/apache/oozie/util/XLogFilter.java (line 65) <https://reviews.apache.org/r/43970/#comment182292> Let's make this package private instead of public. - Robert Kanter On Feb. 24, 2016, 11:31 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43970/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 11:31 p.m.) > > > Review request for oozie. > > > Bugs: https://issues.apache.org/jira/browse/OOZIE-2417 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OOZIE-2417 > > > Repository: oozie-git > > > Description > ------- > > This patch tries to minimize the parsing of same log line for multiple times > using different regex. > It also caches the log parts once we figure out what those are, thus avoiding > the re-parsing of log line to get log parts whenever needed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/util/LogLine.java PRE-CREATION > > core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > 78cb042 > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > f691409 > core/src/main/java/org/apache/oozie/util/XLogFilter.java 3b49f77 > > Diff: https://reviews.apache.org/r/43970/diff/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
