[
https://issues.apache.org/jira/browse/OOZIE-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177865#comment-15177865
]
Ferenc Denes commented on OOZIE-2466:
-------------------------------------
The problem here is, that we sample the 0-9 sequence several times, and expect
the mean to be 4 with delta 0.5.
The sampling is up to the wait above. Normally it is 20 or 21 times (which
results in ~4.29). If the WAITFOR_RATIO is set to be different it is sampled
~20*WAITFOR_RATIO times. The more one samples the closer it is to 4.5
By the floating point representation it might happen, that the value goes above
4.5. An other reason might be, that the sampling window starts at or above 5,
in which case the average is above 4.5.
Overall it should be 4.5 with the same delta.
> Repeated failure of testForNoDuplicates and testSamplers
> --------------------------------------------------------
>
> Key: OOZIE-2466
> URL: https://issues.apache.org/jira/browse/OOZIE-2466
> Project: Oozie
> Issue Type: Test
> Components: build
> Reporter: Manjunath Ballur
> Priority: Trivial
>
> I was looking at, pre-commit builds:
> https://builds.apache.org/job/oozie-trunk-precommit-build/
> Most of the times, the build is failing due to failure of following 2 test
> cases:
> ==============================================================
> org.apache.oozie.event.TestEventGeneration.testForNoDuplicates
> org.apache.oozie.util.TestMetricsInstrumentation.testSamplers
> Every time, these test cases fail with the same error and I feel, they need
> to be fixed.
> Details below:
> ===========
> org.apache.oozie.event.TestEventGeneration.testForNoDuplicates
> ==============================================================
> Error Message
> expected:<3> but was:<4>
> junit.framework.AssertionFailedError: expected:<3> but was:<4>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at junit.framework.Assert.assertEquals(Assert.java:205)
> at
> org.apache.oozie.event.TestEventGeneration.testForNoDuplicates(TestEventGeneration.java:559)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
> at junit.framework.TestResult.runProtected(TestResult.java:128)
> at junit.framework.TestResult.run(TestResult.java:113)
> at junit.framework.TestCase.run(TestCase.java:124)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at junit.framework.TestSuite.run(TestSuite.java:238)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:24)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
>
>
>
> org.apache.oozie.util.TestMetricsInstrumentation.testSamplers
> ==============================================================
> Error Message
> expected:<4.0> but was:<4.508874329129532>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<4.0> but
> was:<4.508874329129532>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:102)
> at junit.framework.Assert.assertEquals(Assert.java:109)
> at
> org.apache.oozie.util.TestMetricsInstrumentation.testSamplers(TestMetricsInstrumentation.java:167)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
> at junit.framework.TestResult.runProtected(TestResult.java:128)
> at junit.framework.TestResult.run(TestResult.java:113)
> at junit.framework.TestCase.run(TestCase.java:124)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at junit.framework.TestSuite.run(TestSuite.java:238)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:24)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
