[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206147#comment-15206147
]
Ferenc Denes commented on OOZIE-2429:
-------------------------------------
[~rkanter] Thanks for the review.
1. I have checked the size of the queue in the previous line, just above the
code quoted here. I made the change now.
The assertEquals is there to catch if there are duplicate elements, in which
case the size will be less than 3.
2. The braces are there to ensure that the variables are not mixed up. It is
not only about formatting. Like it was previously, when one asserted on an
unrelated variable by mistake in this very test. In this way the compiler
checks this case for you. I have kept it as is.
Attached the new patch.
> TestEventGeneration test is flakey
> ----------------------------------
>
> Key: OOZIE-2429
> URL: https://issues.apache.org/jira/browse/OOZIE-2429
> Project: Oozie
> Issue Type: Bug
> Components: action, tests
> Affects Versions: trunk
> Reporter: Ferenc Denes
> Assignee: Ferenc Denes
> Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-2429-1.patch, OOZIE-2429-2.patch,
> OOZIE-2429-3.patch, OOZIE-2429-3.patch, OOZIE-2429-addendum-1.patch
>
>
> TestEventGeneration's testForNoDuplicates fails time to time depending on the
> circumstances of the test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
