[
https://issues.apache.org/jira/browse/OOZIE-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237830#comment-15237830
]
Robert Kanter commented on OOZIE-2391:
--------------------------------------
Overall looks good. Here's a few minor things:
- The Javadoc for {{SparkOptionsSplitter}} has a typo: {{oprtions}} should be
{{options}}
- Instead of making {{SparkOptionsSplitter}} it's own class, I think we should
just make {{SparkOptionsSplitter#split}} a static method in {{SparkMain}}.
- Can you update the Spark Action's doc page to mention how to specify
spark-opts with quotes etc? And an example. The file to edit is named
{{DG_SparkActionExtension.twiki}}.
> spark-opts value in workflow.xml is not parsed properly
> -------------------------------------------------------
>
> Key: OOZIE-2391
> URL: https://issues.apache.org/jira/browse/OOZIE-2391
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Praveen Bathala
> Assignee: Peter Cseh
> Labels: newbie
> Attachments: OOZIE-2391-001.patch, OOZIE-2391-002.patch
>
>
> When providing spark-opts in workflow.xml for oozie, the "--conf" property
> values is not parsed properly.
> Example spark opts
> {code:xml}
> <spark-opts>--conf
> spark.executor.extraJavaOptions=-Dconfig.url=hdfs:///my.conf
> -Dmy.env=${env}</spark-opts>
> {code}
> In this case the value for property "spark.executor.extraJavaOptions" is
> "-Dconfig.url=hdfs:///my.conf -Dmy.env=${env}", but in the oozie code here
> https://github.com/apache/oozie/blob/38e33811bc3f9d3b1a1a024dcab6af760734b696/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java#L110
> the string is just split by space, which make the "-Dmy.env=${env}" a
> separate argument to spark and spark fails job as that argument is not valid.
> This doesn't work with enclosing the whole value in quotes too.
> Error from stderr:
> Error: Unrecognized option '-Dmy.env=development"'.
> Run with --help for usage help or --verbose for debug output
> Intercepting System.exit(1)
> Failing Oozie Launcher, Main class
> [org.apache.oozie.action.hadoop.SparkMain], exit code [1]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
