[
https://issues.apache.org/jira/browse/OOZIE-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250865#comment-15250865
]
Robert Kanter commented on OOZIE-2507:
--------------------------------------
Thanks [~fdenes]. Here's some minor things and then I think we're good to go:
# The docs page and oozie-default.xml have "If the oozie functional metrics
needs to be exposed via JMX interface, set it to true by default." as the
description for the new property. I think the "by default" part is confusing.
We should just make it "If the oozie functional metrics needs to be exposed via
JMX interface, set it to true".
# In {{MetricsInstrumentation}}, there's some unnecessary blank lines added at
the end of the {{isExternalMonitoringEnabled}} if statement.
# {{TestMetricsInstrumentationService#testJMXInstrumentation}} should be moved
to the {{TestMetricsInstrumentation}} class.
# Putting {{System.setProperty("oozie.jmx_monitoring.enable", "true");}} in the
{{setUp()}} method will make it so that any tests run after this one will have
this property set to {{true}}. You should either call {{setSystemProperty}} (a
method in {{XTestCase}} which is setup to restore the original value after the
test method runs) or do something like the call a few lines down in {{setUp}},
where it calls {{services.getConf().set(...)}} to set a config (this will be
reset the next time {{Services}} is recreated).
> Expose monitoring via JMX beans in Oozie
> ----------------------------------------
>
> Key: OOZIE-2507
> URL: https://issues.apache.org/jira/browse/OOZIE-2507
> Project: Oozie
> Issue Type: Improvement
> Components: monitoring
> Affects Versions: trunk
> Reporter: Ferenc Denes
> Assignee: Ferenc Denes
> Priority: Minor
> Fix For: 4.1.0
>
> Attachments: OOZIE-2507-4.patch, OOZIE-2507-6.patch
>
>
> We should please extend oozie to allow monitoring via JMX beans with Zabbix,
> similar to other apps like Jconsole, Nagios, IBM Tivoli, HP OpenVIew, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
