[
https://issues.apache.org/jira/browse/OOZIE-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311219#comment-15311219
]
Rohini Palaniswamy commented on OOZIE-2542:
-------------------------------------------
bq. the patch contains 2 line(s) longer than 132 characters
Please fix this
Please set the default value to "non-finalizing" in oozie-default.xml and
change documentation saying setting empty space will unset the value. I don't
see any reason to have empty space as default and asking users to set it for
this one if this is a safe change. If there are issues after the change with
leaked connections which have been missed, then we can decide to either fix
leaked connections and if that is not possible disable this by default in a
separate jira.
> Option to disable OpenJPA BrokerImpl finalization
> ---------------------------------------------------
>
> Key: OOZIE-2542
> URL: https://issues.apache.org/jira/browse/OOZIE-2542
> Project: Oozie
> Issue Type: Bug
> Reporter: Purshotam Shah
> Assignee: Purshotam Shah
> Attachments: OOZIE-2542-V1.patch, OOZIE-2542-V2.patch
>
>
> We noticed that GC is taking a long time in our production. Looking at the
> live objects, we can see a lot of FinalizingBrokerImpl.
> {code}
> 10: 33881 8402488
> org.apache.openjpa.kernel.FinalizingBrokerImpl
> 15: 91943 3677720 java.lang.ref.Finalizer
> 1134: 1 384 java.lang.ref.Finalizer$FinalizerThread
> 1672: 4 128
> org.apache.hadoop.yarn.proto.YarnProtos$FinalApplicationStatusProto
> 1926: 4 96
> org.apache.hadoop.yarn.api.records.FinalApplicationStatus
> {code}
> By default Broker Finalization is enable to safeguard the accidental resource
> leaks that may occur if a developer fails to explicitly close EntityManagers
> when finished. Since we are closing all EntityManagers on final block. We
> should not have any issue.
> More details @
> http://openjpa.apache.org/builds/1.2.3/apache-openjpa/docs/ref_guide_optimization.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
