[
https://issues.apache.org/jira/browse/OOZIE-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351061#comment-15351061
]
Hadoop QA commented on OOZIE-2584:
----------------------------------
Testing JIRA OOZIE-2584
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1787
. Tests failed: 1
. Tests errors: 0
. The patch failed the following testcases:
.
testCoordActionInputCheckXCommandUniqueness(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommand)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3012/
> Eliminate Thread.sleep() calls in TestMemoryLocks
> -------------------------------------------------
>
> Key: OOZIE-2584
> URL: https://issues.apache.org/jira/browse/OOZIE-2584
> Project: Oozie
> Issue Type: Bug
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Minor
> Attachments: OOZIE-2584-001.patch
>
>
> There are a lot of Thread.sleep() calls in TestMemoryLocks.
> For example:
> {code}
> new Thread(l1).start();
> Thread.sleep(500);
> new Thread(l2).start();
> Thread.sleep(500);
> {code}
> This solution is very fragile. On a slower build machine, Thread2 might
> actually start earlier than Thread1, causing test failure.
> Eliminate sleeps and use a more stable approach for start/stop coordination
> (possibly CountDownLatches).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
