[
https://issues.apache.org/jira/browse/OOZIE-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373997#comment-15373997
]
Robert Kanter commented on OOZIE-2564:
--------------------------------------
A couple things:
# The header in {{oozie-test-log4j.properties}} is twice
#- Looks like most of the log4j.properties files we have are like this. Can
you fix them? https://github.com/apache/oozie/find/master
{noformat}
>> [8] 16:50 : oozie-git (master) :: find . | grep log4j.properties
./core/src/main/conf/oozie-log4j.properties
./core/src/main/resources/localoozie-log4j.properties
./core/src/main/resources/oozie-log4j.properties
./core/src/test/resources/test-custom-log4j.properties
./core/src/test/resources/test-no-dash-log4j.properties
./core/src/test/resources/test-oozie-log4j.properties
./minitest/src/test/resources/oozie-log4j.properties
{noformat}
# Can you rename {{test-oozie-log4j.properties}}? It's used by
{{TestXLogService}}, but it will be confusing to have both
{{test-oozie-log4j.properties}} and {{oozie-test-log4j.properties}}.
# The patch removes a comment {{<!-- DO NOT CHANGE THIS VALUES, TESTCASES
CANNOT RUN IN PARALLEL -->}} from the pom. While it makes sense to remove that
comment, it would be good to have some comment about not running in parallel.
Perhaps just "TESTCASES CANNOT RUN IN PARALLEL"?
> Create new log4j config for unit tests so that logged messages contain threads
> ------------------------------------------------------------------------------
>
> Key: OOZIE-2564
> URL: https://issues.apache.org/jira/browse/OOZIE-2564
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Minor
> Attachments: OOZIE-2564-001.patch, OOZIE-2564-002.patch
>
>
> During the discussion of OOZIE-2550, we concluded that including the threads
> in logged messages is helpful when we run unit tests.
> Note that the log4j config under src/main/resources is not modified.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
