> On July 22, 2016, 10:36 a.m., Jaydeep Vishwakarma wrote: > > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java, line 261 > > <https://reviews.apache.org/r/48470/diff/1/?file=1411989#file1411989line261> > > > > i think validation should come during parsing the filter > > Abhishek Bafna wrote: > This validation can be done while parsing but the thing is, we have > multiple parsing methods (WF, Coord and Bundle into JobsFilterUtils and > CoordinatorEngine). This would require to put the same logic at multiple > places. That is why I have put it there. Also, there is a lot redundant code > is done for Jobs filter API, which I am planning to clean up, once some of > the existing jira's get reviewed. Otherwiese it will increase the work for > existing jira.
ok - Jaydeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48470/#review143213 ----------------------------------------------------------- On June 9, 2016, 6:02 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48470/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 6:02 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2520 > https://issues.apache.org/jira/browse/OOZIE-2520 > > > Repository: oozie-git > > > Description > ------- > > SortBy filter for ordering the jobs query results > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 01efb48 > client/src/main/java/org/apache/oozie/client/OozieClient.java 2ffbd6a > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 79d0d97 > core/src/main/java/org/apache/oozie/DagEngine.java fd83360 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java > 4b631c1 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > bfd1dae > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java > c924f44 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java > 00d2263 > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java d442aa8 > core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 52d3e9d > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 54bfc16 > > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java > 5714040 > > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java > 97cbb7f > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java > 5335213 > > core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java > 46b0d05 > docs/src/site/twiki/DG_CommandLineTool.twiki ff1cce5 > docs/src/site/twiki/WebServicesAPI.twiki a34f2d3 > > Diff: https://reviews.apache.org/r/48470/diff/ > > > Testing > ------- > > Unit tests and manual testing done. > > > Thanks, > > Abhishek Bafna > >
