----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48469/#review143413 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java (line 321) <https://reviews.apache.org/r/48469/#comment209194> where is the refectoring of WorkflowsJobGetJPAExecutor.parseCreatedTimeString, Not seeing removal of the code from there? core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java (line 350) <https://reviews.apache.org/r/48469/#comment209195> mention the correct format. core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java (line 353) <https://reviews.apache.org/r/48469/#comment209193> mention the format as well. core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java (line 21) <https://reviews.apache.org/r/48469/#comment209196> imported only used classes. core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java (line 21) <https://reviews.apache.org/r/48469/#comment209197> same here core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java (line 62) <https://reviews.apache.org/r/48469/#comment209200> can you add some negative condition test cases as well? - Jaydeep Vishwakarma On July 8, 2016, 3:34 p.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48469/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 3:34 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2517 > https://issues.apache.org/jira/browse/OOZIE-2517 > > > Repository: oozie-git > > > Description > ------- > > Add support for startCreatedTime and endCreatedTime filters for coord and > bundles > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 79d0d97 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java > 4b631c1 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > bfd1dae > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java > c924f44 > core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java d442aa8 > core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 52d3e9d > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 54bfc16 > > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java > 5714040 > > core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java > 97cbb7f > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java > 5335213 > > Diff: https://reviews.apache.org/r/48469/diff/ > > > Testing > ------- > > unit tests done. Manual testing done. > > > Thanks, > > Abhishek Bafna > >
