[ 
https://issues.apache.org/jira/browse/OOZIE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404530#comment-15404530
 ] 

Robert Kanter commented on OOZIE-2530:
--------------------------------------

As I said before, we have multiple components, needing different versions of 
jline.  To allow for this, we need to figure out the correct versions for each 
component and set those in the sharelibs.  It seems like Pig isn't pulling in 
jline as a transitive dependency, which is unfortunate, as it makes this more 
of a burden on Oozie.

Looking at the current versions of jline after building Oozie, I see:
{noformat}
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/hive/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/hive2/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/pig/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/spark/jline-0.9.94.jar
./sharelib/target/oozie-sharelib-4.3.0-SNAPSHOT/share/lib/spark/jline-2.10.5.jar
./webapp/target/oozie-webapp-4.3.0-SNAPSHOT/WEB-INF/lib/jline-0.9.94.jar
{noformat}
As it stands, Everything (by default) is using jline 0.9.94, though Spark 
somehow has two versions of it.  Given that, I'd say that the correct thing 
here would be to do something like OOZIE-2409, which specified a different 
version for Hive.  I think what we should do here is to leave jline to 0.9.94 
as-is, add a new {{hive.jline.version}} property in the root pom, set to 0.9.94 
by default for now (we can change it later if we update the minimum Hive 
version), and have the Hive sharelibs use {{hive.jline.version}}.  That's the 
same way we handle a newer guava version for Spark (see 
{{spark.guava.version}}).
Sounds good?

> Remove jline from parent and sharelib pig pom
> ---------------------------------------------
>
>                 Key: OOZIE-2530
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2530
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Thomas Poepping
>         Attachments: OOZIE-2530.01.patch, OOZIE-2530.patch
>
>
> This patch removes an unnecessary hardcoded dependency on jline in the oozie 
> parent pom and pig sharelib pom.
> The jline dependencies were required before OOZIE-704, which removed the 
> direct dependencies on jline in oozie code. Since that patch, the direct 
> dependency on jline in oozie has been unnecessary. This will also fix 
> OOZIE-2409.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to