[
https://issues.apache.org/jira/browse/OOZIE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405015#comment-15405015
]
Robert Kanter commented on OOZIE-2496:
--------------------------------------
This seems fine to me. However, I'm concerned about the overhead of having to
call {{System.getProperty("line.separator")}} so much; it's in a while loop.
Perhaps we should cache the value in a static variable? The tests don't really
matter, so it's mainly just {{TimestampedMessageParser}}.
> Testcase failure due to environment specific line.separator value
> -----------------------------------------------------------------
>
> Key: OOZIE-2496
> URL: https://issues.apache.org/jira/browse/OOZIE-2496
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Environment: Windows
> Reporter: abhishek bafna
> Assignee: abhishek bafna
> Labels: patch
> Attachments: OOZIE-2496-01.patch, OOZIE-2496-02.patch
>
>
> The "line.separator" returns operating system specific line separator. The
> following testcase uses hard coded "\n" while comparing the return values in
> the assertion, which makes them to fail on the windows environment.
> {noformat}
> org.apache.oozie.client.TestOozieCLI#testOozieStatus
> org.apache.oozie.client.TestOozieCLI#testServerBuildVersion
> org.apache.oozie.client.TestOozieCLI#testClientBuildVersion
> {noformat}
> In the following testcase, we are using "line.separator" where as
> _TimestampedMessageParser_ sends the logs after appending "\n".
> {noformat}
> org.apache.oozie.util.TestXLogUserFilterParam#testloglevel_DEBUF_INFO
> org.apache.oozie.util.TestXLogUserFilterParam#testloglevel_Error
> org.apache.oozie.util.TestXLogUserFilterParam#testTextSearch
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
