----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36512/#review146563 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/client/OozieClient.java (line 2215) <https://reviews.apache.org/r/36512/#comment213068> responce typo client/src/main/java/org/apache/oozie/client/OozieClient.java (line 2218) <https://reviews.apache.org/r/36512/#comment213070> use constant for line.seperator core/src/main/java/org/apache/oozie/healthcheck/HdfsHealthCheck.java (line 71) <https://reviews.apache.org/r/36512/#comment213066> dont close the file system , as you are not opening it. core/src/main/java/org/apache/oozie/healthcheck/SharelibMetaFileHealthCheck.java (line 100) <https://reviews.apache.org/r/36512/#comment213161> I am seeing the constant SHARELIB_META_FILE_HEALTH_CHECK have same value. Either we should change the constant value or, use the constant from here to return the value? I feel in future it can be misused. core/src/main/java/org/apache/oozie/healthcheck/SharelibMetaFileHealthCheck.java (line 262) <https://reviews.apache.org/r/36512/#comment213163> final? core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java (line 177) <https://reviews.apache.org/r/36512/#comment213162> new line core/src/main/resources/oozie-default.xml (line 2344) <https://reviews.apache.org/r/36512/#comment213164> newline - Jaydeep Vishwakarma On July 6, 2016, 9:20 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36512/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 9:20 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2306 > https://issues.apache.org/jira/browse/OOZIE-2306 > > > Repository: oozie-git > > > Description > ------- > > Oozie can be configured to check the health of its components. > http://localhost:11000/oozie/v2/admin/health will report the health of > configured components and time taken to compute health check (this can be > used to find component slowness). > Health check component can be configured with below properties. > <verbatim> > <property> > <name>oozie.healthCheck.components</name> > <value>org.apache.oozie.healthcheck.DataBaseHealthCheck</value> > <description> > </description> > </property> > </verbatim> > Support components are DataBaseHealthCheck, HdfsHealthCheck, > SharelibHealthCheck, SharelibMetaFileHealthCheck and ZKHealthCheck. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 65291ff1303cb0e8419e2930521d26c0b3cd7142 > client/src/main/java/org/apache/oozie/client/OozieClient.java > 67a62c622a9ef86afb82b492735d146faba427de > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > b3b148acb8e0b71b6233937b793453009a4faf2a > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 3c6931915a1afb3ead4b12e1b9ea3c02835c0b5d > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 4fc0c52396165ea9e8add98368e360e3ec989b77 > core/src/main/java/org/apache/oozie/healthcheck/DataBaseHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/healthcheck/HdfsHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/healthcheck/HealthCheckExecutor.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/healthcheck/HealthCheckExecutorHTML.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/healthcheck/HealthCheckExecutorJson.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/healthcheck/HealthCheckStatus.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/healthcheck/OozieHealthCheckComponent.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/healthcheck/SharelibHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/healthcheck/SharelibMetaFileHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/healthcheck/ZKHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/service/ShareLibService.java > 81a9f2d5da781ff79b9bcb1cb5cca02575d57b49 > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 64d3f1f40c5c7b3746ad410cf43f80925424d094 > core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java > 059d3cf6dc251b49940af29d82cbdd817043a176 > core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java > fd573d51b77d86c77e944b4d49e1f77f30eb6a26 > core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 965a19a2f14e4ba10e5977bf042a2d3c2e47d525 > core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java > 7eadbe781e58f5bb674930288416ac4e7f0c3ae0 > core/src/main/resources/oozie-default.xml > 3ff7320df003a0ee05f767ffcf3d9a2b0b448d07 > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > 54bfc16131ed20218ef56e028a69a5507432bd1a > > core/src/test/java/org/apache/oozie/healthcheck/TestDataBaseHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/test/java/org/apache/oozie/healthcheck/TestSharelibMetaFileHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/test/java/org/apache/oozie/healthcheck/TestZKHealthCheck.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/test/java/org/apache/oozie/service/ShareLibServiceTestCases.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > 842b2d53ed1f996f694c8960384e8455a9923372 > docs/src/site/twiki/AG_Install.twiki > 66c00199a3ef457cd495ec8b9717823b820d958a > docs/src/site/twiki/DG_CommandLineTool.twiki > ff1cce532efc3eb3b6c7e4e53f6db6b3ef26d718 > docs/src/site/twiki/WebServicesAPI.twiki > a34f2d354e6f073a6f89d951af36cffb0f8dadd8 > > Diff: https://reviews.apache.org/r/36512/diff/ > > > Testing > ------- > > Added enough test cases and checked manually. > > > Thanks, > > Purshotam Shah > >
