----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50202/#review146921 -----------------------------------------------------------
I'll need to spend some more time going through the forkjoin validation logic, but here's some feedback so far. core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java (line 49) <https://reviews.apache.org/r/50202/#comment213742> If this somehow does happen, this will bring down the entire Oozie Server! Instead, we should throw a WorkflowException so that it fails the Workflow. core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java (line 78) <https://reviews.apache.org/r/50202/#comment213743> it only has supported action nodes core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java (line 88) <https://reviews.apache.org/r/50202/#comment213748> constraints core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java (line 95) <https://reviews.apache.org/r/50202/#comment213745> I'd put this logic back in here. It's doing a few different things depending on the node type and it would be easier to follow if they were right here instead of far away in another method. core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java (line 134) <https://reviews.apache.org/r/50202/#comment213747> contraints core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java (lines 149 - 154) <https://reviews.apache.org/r/50202/#comment213749> I like the diagram and giant comments :) core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java (line 296) <https://reviews.apache.org/r/50202/#comment213744> Again, let's throw a WorkflowException. core/src/test/java/org/apache/oozie/TestWorkflowBean.java (lines 35 - 37) <https://reviews.apache.org/r/50202/#comment213750> Unrelated changes core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java (line 1446) <https://reviews.apache.org/r/50202/#comment213752> This should scale using the same parameter as waitFor in XTestCase. - Robert Kanter On July 23, 2016, 5:54 p.m., Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50202/ > ----------------------------------------------------------- > > (Updated July 23, 2016, 5:54 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1978 > https://issues.apache.org/jira/browse/OOZIE-1978 > > > Repository: oozie-git > > > Description > ------- > > See OOZIE-1978 for details. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/ErrorCode.java 2907ca2 > core/src/main/java/org/apache/oozie/service/ActionService.java becc69b > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > a1b9cdb > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowValidator.java > PRE-CREATION > core/src/test/java/org/apache/oozie/TestWorkflowBean.java b68f0f7 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 73464c8 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 9002b6c > core/src/test/resources/wf-long.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/50202/diff/ > > > Testing > ------- > > Existing tests pass. > > We might need to add some more, at least testing acyclic graph detection. > > > Thanks, > > Peter Bacsko > >
