> On Aug. 31, 2016, 1:32 p.m., Attila Sasvari wrote: > > core/src/test/java/org/apache/oozie/test/MiniHCatServer.java, line 150 > > <https://reviews.apache.org/r/51174/diff/1/?file=1476401#file1476401line150> > > > > Please safely delete this method if it is not required anymore.
Dropped this code is not in the updated patch. > On Aug. 31, 2016, 1:32 p.m., Attila Sasvari wrote: > > core/src/test/java/org/apache/oozie/test/XTestCase.java, line 997 > > <https://reviews.apache.org/r/51174/diff/1/?file=1476403#file1476403line997> > > > > Can you please extract new Path("/tmp/hive") to a local variable to > > avoid duplication? Dropped this code is not in the updated patch. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51174/#review147428 ----------------------------------------------------------- On Aug. 17, 2016, 10:38 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51174/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 10:38 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2613 > https://issues.apache.org/jira/browse/OOZIE-2613 > > > Repository: oozie-git > > > Description > ------- > > Upgrade hive version from 0.13.1 to 1.2.0 > > > Diffs > ----- > > core/pom.xml f19d83b > core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java > 5345ae6 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 5f9e29a > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 10498cb > core/src/test/java/org/apache/oozie/test/MiniHCatServer.java 8699ff8 > core/src/test/java/org/apache/oozie/test/XHCatTestCase.java 85ee1f2 > core/src/test/java/org/apache/oozie/test/XTestCase.java 8ce44f3 > pom.xml 9e06e89 > sharelib/hive/pom.xml 73802da > sharelib/hive2/pom.xml d660b90 > > Diff: https://reviews.apache.org/r/51174/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
