Re: Review Request 31103: OOZIE-2134 Remove references to Services.get().getConf() in code

Azrael Seoeun Park Mon, 05 Sep 2016 23:55:40 -0700

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31103/
-----------------------------------------------------------


(Updated Sept. 6, 2016, 6:55 a.m.)


Review request for oozie.


Changes
-------

# Remove ConfigrautionService#getInt(String name, int default) 
We should not use code default, use oozie-default.xml. (OOZIE-1890)

# Add XTestCase#initNewServices(Properties configuration)
Construct and initialize Services with configuration for testing.


Bugs: OOZIE-2134
    https://issues.apache.org/jira/browse/OOZIE-2134


Repository: oozie-git


Description
-------

To set the configuration for the test cases, I added {{ 
XTestCase#getOozieConfiguration(Services services) }}.
Patch was written without --no-prefix option.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/CoordinatorEngine.java cec6347 
  core/src/main/java/org/apache/oozie/action/ActionExecutor.java 3f978fd 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
0574584 
  core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java 
9609fdc 
  core/src/main/java/org/apache/oozie/command/XCommand.java bdf13f6 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java
 d51f0d7 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 6d8aa0f 
  
core/src/main/java/org/apache/oozie/command/coord/CoordStatusTransitXCommand.java
 ab8aa83 
  core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java 
cae9591 
  core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 22eb1c3 
  core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java 
09b110e 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
 9db9daa 
  core/src/main/java/org/apache/oozie/local/LocalOozie.java bf1b0db 
  core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 1afd01b 
  core/src/main/java/org/apache/oozie/service/ActionService.java becc69b 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java f281873 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java a86a8d0 
  core/src/main/java/org/apache/oozie/service/CallbackService.java 405701d 
  core/src/main/java/org/apache/oozie/service/ConfigurationService.java 524d4d6 
  
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 
1cbd474 
  core/src/main/java/org/apache/oozie/service/DBLiteWorkflowStoreService.java 
4f2c350 
  core/src/main/java/org/apache/oozie/service/ELService.java d27d47f 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 22c6fb0 
  core/src/main/java/org/apache/oozie/service/GroupsService.java f911568 
  core/src/main/java/org/apache/oozie/service/HCatAccessorService.java 249b663 
  core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 
f171ea3 
  core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
3d887bb 
  core/src/main/java/org/apache/oozie/service/JMSAccessorService.java e6dc440 
  core/src/main/java/org/apache/oozie/service/JMSTopicService.java 35c82c3 
  core/src/main/java/org/apache/oozie/service/JPAService.java 028381d 
  core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 
da2b9aa 
  core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java 
f0c72f3 
  
core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java 
b57a2a5 
  
core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
 b59361b 
  core/src/main/java/org/apache/oozie/service/PauseTransitService.java 823cc5f 
  core/src/main/java/org/apache/oozie/service/ProxyUserService.java 39b5774 
  core/src/main/java/org/apache/oozie/service/PurgeService.java 6e4a8e8 
  core/src/main/java/org/apache/oozie/service/RecoveryService.java 64a67d6 
  core/src/main/java/org/apache/oozie/service/SchedulerService.java 81fbc0d 
  core/src/main/java/org/apache/oozie/service/Services.java 829d5f5 
  core/src/main/java/org/apache/oozie/service/ShareLibService.java b79bd37 
  core/src/main/java/org/apache/oozie/service/StatusTransitService.java 4c4a022 
  core/src/main/java/org/apache/oozie/service/URIHandlerService.java c4a3701 
  core/src/main/java/org/apache/oozie/service/UUIDService.java 313f9dd 
  core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 6891bbe 
  core/src/main/java/org/apache/oozie/service/WorkflowSchemaService.java 
ce96371 
  core/src/main/java/org/apache/oozie/service/XLogStreamingService.java c15c4c1 
  core/src/main/java/org/apache/oozie/service/ZKLocksService.java 952b90d 
  core/src/main/java/org/apache/oozie/servlet/AuthFilter.java 38d575d 
  core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java 7eadbe7 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java e8638a9 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java 08cd07e 
  core/src/main/java/org/apache/oozie/util/StatusUtils.java 24eba21 
  core/src/main/java/org/apache/oozie/util/ZKUtils.java 8069641 
  core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java d11f7dc 
  core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java 285827d 
  core/src/main/resources/oozie-default.xml 40a5fe5 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java 
3eb1016 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 
354176e 
  core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 
386fef3 
  core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 
5345ae6 
  core/src/test/java/org/apache/oozie/action/hadoop/TestHCatPrepareActions.java 
d66d9c9 
  core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java aa938d0 
  
core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherHCatURIHandler.java
 66d4ecc 
  core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 
5bc7d00 
  
core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 
1531ed9 
  
core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
 e074d48 
  core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java 20a59c0 
  
core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 
cfb8b4e 
  core/src/test/java/org/apache/oozie/command/coord/TestBulkCoordXCommand.java 
27e294d 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
 bbe9ea7 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java
 e0e2251 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java
 c9b2f28 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java 
7062e69 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 
552d832 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 
111eace 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
 29e7ca1 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java
 25f250c 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 
cdfc9d6 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 
dcc97ad 
  core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 
5898d1a 
  core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 45cbbc4 
  core/src/test/java/org/apache/oozie/command/wf/TestSignalXCommand.java 
1f6333c 
  core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 
8cc3694 
  core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java a14641b 
  core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java e1cf133 
  
core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java
 6684a1f 
  core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java 
a49eba5 
  core/src/test/java/org/apache/oozie/event/TestEventGeneration.java afd3f8f 
  core/src/test/java/org/apache/oozie/event/TestEventQueue.java 3bb6c56 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsDeleteJPAExecutor.java
 9077970 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteJPAExecutor.java
 c7e0c38 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java
 4aa5de8 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java
 fb15d6a 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsDeleteJPAExecutor.java
 bff5836 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java
 fd80e74 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsBasicInfoFromCoordParentIdJPAExecutor.java
 ba01f29 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsBasicInfoFromWorkflowParentIdJPAExecutor.java
 e275520 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsDeleteJPAExecutor.java
 c4ca61b 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromCoordParentIdJPAExecutor.java
 4a58ab2 
  
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetFromWorkflowParentIdJPAExecutor.java
 41c00a9 
  core/src/test/java/org/apache/oozie/jms/TestDefaultConnectionContext.java 
e941a8e 
  core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java 1a1a44e 
  core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java 728916e 
  core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java 30fd151 
  core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 
c465c7f 
  core/src/test/java/org/apache/oozie/service/TestActionService.java 5b5ac93 
  core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 
ce461c1 
  core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 
f18a8c0 
  core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java 
53b7f62 
  core/src/test/java/org/apache/oozie/service/TestGroupsService.java d1abc6e 
  
core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerEhCache.java
 24ff36b 
  
core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java
 d681d42 
  core/src/test/java/org/apache/oozie/service/TestHASLAService.java 3af263e 
  core/src/test/java/org/apache/oozie/service/TestHAShareLibService.java 
791f568 
  core/src/test/java/org/apache/oozie/service/TestHCatAccessorService.java 
b195fb7 
  core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 
bbe2594 
  core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java 
505049d 
  core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java 383e53e 
  core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java 
011a574 
  core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 
560fedb 
  
core/src/test/java/org/apache/oozie/service/TestMetricsInstrumentationService.java
 59945a7 
  
core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java
 b844145 
  
core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
 a5d2ed9 
  core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 
677a360 
  core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 47affc2 
  core/src/test/java/org/apache/oozie/service/TestPurgeService.java 74d34cc 
  core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 8fd0c2d 
  core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 
0bcbce0 
  core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java ce731a1 
  
core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 
04fde73 
  core/src/test/java/org/apache/oozie/servlet/TestBulkMonitorWebServiceAPI.java 
b4054b0 
  core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java 
7e1921e 
  core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 06f54f2 
  core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 7d40e31 
  core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1e19923 
  core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd 
  core/src/test/java/org/apache/oozie/test/XTestCase.java 8ce44f3 
  core/src/test/java/org/apache/oozie/test/ZKXTestCase.java dfbea88 
  core/src/test/java/org/apache/oozie/util/TestConfigUtils.java 6904881 
  core/src/test/java/org/apache/oozie/util/TestXLogUserFilterParam.java 46f273f 
  
sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 2713526 
  tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 8ada2e4 
  tools/src/main/java/org/apache/oozie/tools/OozieDBExportCLI.java 740a48b 
  tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java 0e14a30 
  tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 9aa4cb6 
  tools/src/test/java/org/apache/oozie/tools/TestOozieSharelibCLI.java 7fff802 
  
zookeeper-security-tests/src/test/java/org/apache/oozie/test/ZKXTestCaseWithSecurity.java
 f9f3e88 
  
zookeeper-security-tests/src/test/java/org/apache/oozie/util/TestZKUtilsWithSecurity.java
 ffced02 

Diff: https://reviews.apache.org/r/31103/diff/


Testing
-------

Unit Test.
Manual Test.


Thanks,

Azrael Seoeun Park

Re: Review Request 31103: OOZIE-2134 Remove references to Services.get().getConf() in code

Reply via email to