[
https://issues.apache.org/jira/browse/OOZIE-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514238#comment-15514238
]
Rohini Palaniswamy commented on OOZIE-2582:
-------------------------------------------
Thanks for the cleanup. Have few more comments.
- Remove comment // See JavaActionExecutor#readExternalChildIDs for how they
are read
- getHadoopJobIds should just return String and if it is null then
writeExternalChildIds should skip creating the file
- You are now creating string as "job_id1, job_id2" instead of
"job_id1,job_id2". i.e extra space after comma which will require trimming
later. Instead of jobIds.toString().substring(1,
jobIds.toString().length()-1), please do
{code}
if (jobIds.isEmpty()) {
return null;
}
else {
return StringUtils.join(",");
}
{code}
> Populating external child Ids for action failures
> -------------------------------------------------
>
> Key: OOZIE-2582
> URL: https://issues.apache.org/jira/browse/OOZIE-2582
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Abhishek Bafna
> Assignee: Abhishek Bafna
> Fix For: 4.3.0
>
> Attachments: OOZIE-2582-00.patch, OOZIE-2582-01.patch,
> OOZIE-2582-02.patch, OOZIE-2582-03.patch, OOZIE-2582-04.patch,
> OOZIE-2582-05.patch, OOZIE-2582-06.patch
>
>
> Currently Oozie external child ids are populated into workflow bean, when the
> job/action completes successfully. It should populate external child ids in
> case of job failures as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
