> On Sept. 19, 2016, 11:44 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java, > > line 548 > > <https://reviews.apache.org/r/44204/diff/2/?file=1487474#file1487474line548> > > > > Assume.assumeTrue("Skip this test for Hadoop 1.x", > > HadoopShims.isYARN()); > > Jaydeep Vishwakarma wrote: > How does this work. Do you want me to replace this with "if > (HadoopShims.isYARN()) {". This test case will not work for 1.x. Please guide > me.
Yes. The above statement should be used instead of the if condition. The test will show up as Skipped when run with 1.x instead of Passed. You can refer http://junit.sourceforge.net/javadoc/org/junit/Assume.html Since patch is already committed, you can just put a amend patch with just this change in same jira and I will +1 for that. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44204/#review149565 ----------------------------------------------------------- On Aug. 27, 2016, 7:46 p.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44204/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2016, 7:46 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2243 > https://issues.apache.org/jira/browse/OOZIE-2243 > > > Repository: oozie-git > > > Description > ------- > > Whenever the coord action or workflow gets killed only the job that has error > gets killed while the other hadoop jobs keeps on running and only the > workflow status gets changed to killed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > e546e77 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > ed06707 > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 1ea7097 > core/src/test/java/org/apache/hadoop/examples/SleepJob.java 8dec534 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 5f9e29a > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > dca7820 > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > ce8c14f > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > 94e01ea > > Diff: https://reviews.apache.org/r/44204/diff/ > > > Testing > ------- > > done > > > Thanks, > > Jaydeep Vishwakarma > >
