[ 
https://issues.apache.org/jira/browse/OOZIE-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Bacsko updated OOZIE-2700:
--------------------------------
    Description: 
In the scope of OYA, we have the opportunity to increase the code quality of 
Oozie.

The following things could be improved:
* Remove hard-coded, repeated strings and place them to static variables
* Eliminate unnecessary {{@SuppressWarnings}} annotations
* Proper usage of generics, eg. {{Class<?>}} instead of just {{Class}}
* Replace deprecated method calls to something else, for example:
** {{DistributedCache.addCacheFile()}}
** {{DistributedCache.createSymlink()}}
** {{SequenceFile.Reader()}} (two deprecated constructors)
* Remove unused imports
* In general, we should look for compile time warnings and take appropriate 
actions to resolve them, if possible
* Remove duplicated version definitions in POMs
* Delete trailing white spaces
* Check for lines which are longer than 132 chars

Note that these changes are very small and don't require large testing efforts.

The list above is not exhaustive, so feel free to include ideas.

  was:
In the scope of OYA, we have the opportunity to increase the code quality of 
Oozie.

The following things could be improved:
* Remove hard-coded, repeated strings and place them to static variables
* Eliminate unnecessary {{@SuppressWarnings}} annotations
* Proper usage of generics, eg. {{Class<?>}} instead of just {{Class}}
* Replace deprecated method calls to something else, for example:
** {{DistributedCache.addCacheFile()}}
** {{DistributedCache.createSymlink()}}
** {{SequenceFile.Reader()}} (two deprecated constructors)
* Remove unused imports
* In general, we should look for compile time warnings and take appropriate 
actions to resolve them, if possible
* Delete trailing white spaces
* Check for lines which are longer than 132 chars

Note that these changes are very small and don't require large testing efforts.

The list above is not exhaustive, so feel free to include ideas.


> Misc code cleanup
> -----------------
>
>                 Key: OOZIE-2700
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2700
>             Project: Oozie
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>
> In the scope of OYA, we have the opportunity to increase the code quality of 
> Oozie.
> The following things could be improved:
> * Remove hard-coded, repeated strings and place them to static variables
> * Eliminate unnecessary {{@SuppressWarnings}} annotations
> * Proper usage of generics, eg. {{Class<?>}} instead of just {{Class}}
> * Replace deprecated method calls to something else, for example:
> ** {{DistributedCache.addCacheFile()}}
> ** {{DistributedCache.createSymlink()}}
> ** {{SequenceFile.Reader()}} (two deprecated constructors)
> * Remove unused imports
> * In general, we should look for compile time warnings and take appropriate 
> actions to resolve them, if possible
> * Remove duplicated version definitions in POMs
> * Delete trailing white spaces
> * Check for lines which are longer than 132 chars
> Note that these changes are very small and don't require large testing 
> efforts.
> The list above is not exhaustive, so feel free to include ideas.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to