----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52217/#review151466 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java (line 58) <https://reviews.apache.org/r/52217/#comment219820> You can use the diamond operator of Java 7 List<Class<?>> classes = new ArrayList<>(); core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java (line 57) <https://reviews.apache.org/r/52217/#comment219822> Use the diamond operator core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java (line 59) <https://reviews.apache.org/r/52217/#comment219823> Use diamond operator core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 157) <https://reviews.apache.org/r/52217/#comment219824> Use the Diamond operator core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java (line 57) <https://reviews.apache.org/r/52217/#comment219826> Use the diamond operator core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java (line 50) <https://reviews.apache.org/r/52217/#comment219827> Use the diamond operator core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java (line 132) <https://reviews.apache.org/r/52217/#comment219828> Use the diamond operator core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java (line 58) <https://reviews.apache.org/r/52217/#comment219829> Use the diamond operator core/src/main/java/org/apache/oozie/service/JPAService.java (line 177) <https://reviews.apache.org/r/52217/#comment219830> Is it related to this task? MySQL replication shall be handled in a different JIRA. core/src/main/java/org/apache/oozie/service/Services.java (line 287) <https://reviews.apache.org/r/52217/#comment219831> Use diamond operator core/src/main/java/org/apache/oozie/service/ShareLibService.java (line 428) <https://reviews.apache.org/r/52217/#comment219832> Is there any reason not putting this into the for statement's increment expression? core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (line 278) <https://reviews.apache.org/r/52217/#comment219833> Remove commented out code core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (line 448) <https://reviews.apache.org/r/52217/#comment219836> What happens if it never finishes? For example if the application fails, it will be in the FAILED state. core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (line 586) <https://reviews.apache.org/r/52217/#comment219837> What shall be fixed? core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (line 1610) <https://reviews.apache.org/r/52217/#comment219838> Remove commented out code. Write new test case if necessary. core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java (line 41) <https://reviews.apache.org/r/52217/#comment219841> Remove if not needed core/src/test/java/org/apache/oozie/service/TestShareLibService.java (line 116) <https://reviews.apache.org/r/52217/#comment219846> Syntax does not look right Lists.<Class<?>>newArrayList(TestHive.class); core/src/test/java/org/apache/oozie/test/XTestCase.java (line 1199) <https://reviews.apache.org/r/52217/#comment219859> Is this really needed? (Making it final and Mutable decreases readability in my opinion.) core/src/test/java/org/apache/oozie/test/XTestCase.java (line 1225) <https://reviews.apache.org/r/52217/#comment219856> Is it needed? If statement at line 1211 seems to check this. (If states contains state, then then this function returns with true, otherwise with false.) sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java (line 257) <https://reviews.apache.org/r/52217/#comment219861> Can you please also add new unit tests? - Attila Sasvari On Sept. 26, 2016, 12:28 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52217/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 12:28 p.m.) > > > Review request for oozie, Jaydeep Vishwakarma, Purshotam Shah, Robert Kanter, > and Rohini Palaniswamy. > > > Bugs: OOZIE-2591 > https://issues.apache.org/jira/browse/OOZIE-2591 > > > Repository: oozie-git > > > Description > ------- > > Java action is working. > There are some things in there which are still temporary, we're opening > follow-up jiras to address them. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/WorkflowJobBean.java > 55d79a5d5e5e4efab9eb832e9341a16bcf8959cc > core/src/main/java/org/apache/oozie/action/hadoop/Credentials.java > eadb47b07d157f45f086517ab41c4b9826f003f0 > core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProvider.java > 6fe22fbd2fca5d873d58ece60f20d0f131371475 > core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 99652e836a012811fb0cbd78856ccf5f0ff56b70 > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 121cd49bc1077530892aa593581f50ce89ac365d > core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java > 801bfe6eb212b549888f0e9fb7df7b65bcf59393 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java > 428975e4625b32c4c90284a93a726df490f58b70 > core/src/main/java/org/apache/oozie/action/hadoop/HadoopELFunctions.java > c32288783d8e5cb0f3bf758fa0580a6cd7aed93a > core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java > 307f565786ad77f5a35b5790bd5b052b04c6eac8 > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > 9ba6318a77ffa17e93c8d5babd5ee97ba96dc57f > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > a8509578684287e0aed9a76dcc9778e3ee9a54e0 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > d573fc35a2f2d971c97a1ff046469b0698ee92cb > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 07d1262d1410f089de40a32367351830c4d7269c > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > de8290efb78739596e79dea41e1be92c70909333 > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java > 581d3b3219eff882f961c8e495611e873c6a5a52 > core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 8b2dc16db80ad602911f1f64e60cfad41b198922 > > core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java > f2541265ca71fb7f3b053c59775ef5e23d0d8f94 > core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > 4fdd3ff9d5d611916e1312f669a4df1f014f7970 > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 6a41235768bc87542e8c041b78ecace260fc96ba > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 82e5f0cedd4c32d6b2d269ffcc080172c787ec49 > core/src/main/java/org/apache/oozie/service/JPAService.java > fd3f6cb2242619ec7b7fbce68e0675fb1324b6f5 > core/src/main/java/org/apache/oozie/service/Services.java > 829d5f5cd90c86e6cba9854dc0b4b7df570b8900 > core/src/main/java/org/apache/oozie/service/ShareLibService.java > fa230da8ce2b66fe97395ca9ccf4bdd6013a31b1 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 794ad813c92febae0747d5a5396528f5ea686589 > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > aa938d01b7273d6db273908e5480b71613598135 > core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java > f503b1f6a19189e51ceb410eb973005491a956a8 > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > 6f254521c220f48b83a86a517136ea7949ba9cb6 > core/src/test/java/org/apache/oozie/test/XTestCase.java > 81a33fdad9091bb2dd809f41a3cd04f06ec21f10 > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java > 32c743435f3ac3d17566f353af9f406374b1057f > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > e056acc7f815455452c843a9ec847157a66c932f > > Diff: https://reviews.apache.org/r/52217/diff/ > > > Testing > ------- > > > Thanks, > > Peter Cseh > >
