[
https://issues.apache.org/jira/browse/OOZIE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571719#comment-15571719
]
Hadoop QA commented on OOZIE-2644:
----------------------------------
Testing JIRA OOZIE-2644
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:red}-1{color} the patch contains 2 line(s) longer than 132
characters
. {color:green}+1{color} the patch does adds/modifies 5 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1823
. Tests failed: 2
. Tests errors: 0
. The patch failed the following testcases:
.
testSkipNotificationCommand(org.apache.oozie.command.coord.TestCoordActionNotificationXCommand)
.
testQueueNotificationCommand(org.apache.oozie.command.coord.TestCoordActionNotificationXCommand)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3377/
> Skip queuing Notification Commands when there's nothing to notify
> -----------------------------------------------------------------
>
> Key: OOZIE-2644
> URL: https://issues.apache.org/jira/browse/OOZIE-2644
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: 3.1.3
> Reporter: Robert Kanter
> Assignee: Azrael Seoeun
> Fix For: 5.0.0
>
> Attachments: OOZIE-2644.1.patch
>
>
> When you use the
> [Workflow|https://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a5_Workflow_Notifications]
> or
> [Coordinator|https://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a15._Coordinator_Notifications]
> Notification features, Oozie can end up queuing up a lot of
> {{WorkflowNotificationXCommand}} and {{CoordActionNotificationXCommand}}.
> This happens even if there's no notification configured on the job (which I
> imagine is most of the time); in this case, the {{execute}} method simply
> does nothing. This is wasteful and clogs the queue up.
> We should change the code so that it doesn't queue up one of these Commands
> unless there's actually a URL to notify.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
