Peter Cseh commented on OOZIE-2709:

Thank you for working on this [~satishsaley]! 
Some minor suggestions:
# It looks like there are 3 lines in PigActionExecutor which are added but 
commented out - probably leftover
# In logExpandedList there is a {{new LinkedList<String>()}} call. It cloud be 
and {{ArrayList}} or you could define and array with size 
{{arguments.size()+1}} and set the last element to -dryrun.
# would it make sense to check for the {{.substituted}} file if there is no 
{{.expanded}} because there are no macros in the file? (I'm not that familiar 
with Pig and how people use it)
# we should figure out how to write tests for log contents as we have many 
logging related tasks (it's not part of this particular issue, just mentioning 

> Log the substituted pig script by expanding macros
> --------------------------------------------------
>                 Key: OOZIE-2709
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2709
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Satish Subhashrao Saley
>            Assignee: Satish Subhashrao Saley
>         Attachments: OOZIE-2709-1.patch
> Ask from [~knoguchi] to make life easier when debugging pig scripts with lots 
> of macros.

This message was sent by Atlassian JIRA

Reply via email to