[
https://issues.apache.org/jira/browse/OOZIE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606926#comment-15606926
]
Robert Kanter commented on OOZIE-1986:
--------------------------------------
[~andras.piros], thanks for working on the amend patch. Two things:
# Can you look into the RAT warning? You may need to add another file to the
exclusions.
# This line seems odd to me, though I'm not a bash expert so it could be
correct:
{code}
done < <(find "${sourceFolder}" -name ${FINDBUGS_XML_NAME} -print0)
{code}
In particular, the {{done < <(}} part. What does two {{<}} separated like
that do?
#- This makes me think of Kirby {{<('o'<)}} :)
> Add FindBugs report to pre-commit build
> ---------------------------------------
>
> Key: OOZIE-1986
> URL: https://issues.apache.org/jira/browse/OOZIE-1986
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Reporter: Robert Kanter
> Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-1986-amend.001.patch, OOZIE-1986.001.patch,
> OOZIE-1986.002.patch, OOZIE-1986.003.patch, OOZIE-1986.004.patch,
> OOZIE-1986.005.patch, OOZIE-1986.006.patch, OOZIE-1986.007.patch,
> OOZIE-1986.008.patch, OOZIE-1986.009.patch, OOZIE-1986.010.patch, summary.txt
>
>
> Now that we have OOZIE-1793, it will be really useful to have the pre-commit
> build generate a findbugs report. It should probably before and after the
> patch and only complain it there are more after. And it should link to the
> report. Ideally, this would do some kind of diff (like Hadoop does) so it's
> easy to identify the new findbugs items.
> You can generate the findbugs reports by running:
> {noformat}
> mvn verify -DskipTests
> {noformat}
> This also runs checkstyle
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
