[
https://issues.apache.org/jira/browse/OOZIE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670580#comment-15670580
]
Hadoop QA commented on OOZIE-2739:
----------------------------------
Testing JIRA OOZIE-2739
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} FindBugs diff JAR has a weird MD5 sum, rejecting.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 1828
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3441/
> Remove property expansion pattern from ShellMain's log4j properties content
> ---------------------------------------------------------------------------
>
> Key: OOZIE-2739
> URL: https://issues.apache.org/jira/browse/OOZIE-2739
> Project: Oozie
> Issue Type: Bug
> Components: action
> Affects Versions: 4.3.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: OOZIE-2739.patch
>
>
> In OOZIE-2504 the following XML was added:
> {code}
> <property>
> <name>oozie.action.shell.setup.hadoop.conf.dir.log4j.content</name>
> <value>
> log4j.rootLogger=${hadoop.root.logger}
> hadoop.root.logger=INFO,console
> log4j.appender.console=org.apache.log4j.ConsoleAppender
> log4j.appender.console.target=System.err
> log4j.appender.console.layout=org.apache.log4j.PatternLayout
> log4j.appender.console.layout.ConversionPattern=%d{yy/MM/dd
> HH:mm:ss} %p %c{2}: %m%n
> </value>
> {code}
> The intention was to place the value of this configuration as-is into a
> generated log4j.properties when the ShellMain prepares the sub-environment.
> However, due to Apache Hadoop Common's Configuration class recognizing the
> dollar-brace syntax as a substitution variable, and also subsequently finding
> {{hadoop.root.logger}} set as a system property within task container
> environments, sets the written file to carry the line
> "log4j.rootLogger=INFO,CLA" or "log4j.rootLogger=INFO,CLRA".
> This in turn causes odd warnings from log4j to appear, about there being no
> such appender defined (which was intentional, i.e. to move out of CLA and
> onto console for the sub-commands).
> There's no way to write out the substitution syntax in a way that
> Configuration class wouldn't substitute it, so we should likely hard-code the
> value to be {{INFO,console}}. Those who wish to change it can do so at action
> levels with the whole new content anyway.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
