> On Dec. 1, 2016, 12:58 p.m., András Piros wrote: > > Hi Abhishek, > > > > tremendous job done, thanks! > > > > Nevertheless, following Javadoc warnings are still present w/ JDK 1.8.0_102: > > > > ``` > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Building Apache Oozie Core 4.4.0-SNAPSHOT > > [INFO] > > ------------------------------------------------------------------------ > > 2 warnings > > [WARNING] Javadoc Warnings > > [WARNING] > > /Users/forsage/Workspace/oozie/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java:183: > > warning - @param argument "startInst:" is not a parameter name. > > [WARNING] > > /Users/forsage/Workspace/oozie/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java:183: > > warning - @param argument "endInst:" is not a parameter name. > > > > ``` > > > > Can you please address these as well?
Thanks András Piros. I have addressed your comment. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53878/#review157584 ----------------------------------------------------------- On Nov. 18, 2016, 4:24 p.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53878/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 4:24 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2681 > https://issues.apache.org/jira/browse/OOZIE-2681 > > > Repository: oozie-git > > > Description > ------- > > fix javadoc to compile on JDK8 again > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/CLIParser.java c3dd9b3 > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 807cf22 > client/src/main/java/org/apache/oozie/client/Job.java 277e112 > client/src/main/java/org/apache/oozie/client/OozieClient.java 12c80cb > client/src/main/java/org/apache/oozie/client/XOozieClient.java 8538ec7 > > client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java > df3b237 > > client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 8337baf > > client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java > d6209c5 > > client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java > 382bb82 > client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > c51b2f9 > client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java > 96f9d67 > > client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java > b204ccd > core/src/main/java/org/apache/oozie/BaseEngine.java 50df897 > core/src/main/java/org/apache/oozie/BinaryBlob.java d1971fc > core/src/main/java/org/apache/oozie/BundleActionBean.java ccc18d9 > core/src/main/java/org/apache/oozie/BundleEngine.java d0099b4 > core/src/main/java/org/apache/oozie/BundleJobBean.java 5868412 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java b1be7c9 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 91fe5a1 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 3a3120d > core/src/main/java/org/apache/oozie/DagEngine.java 7597142 > core/src/main/java/org/apache/oozie/LocalOozieClient.java f734f76 > core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 32b0cd0 > core/src/main/java/org/apache/oozie/StringBlob.java 9e8d383 > core/src/main/java/org/apache/oozie/WorkflowActionBean.java 974c52b > core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1d6456b > core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProvider.java > 6fe22fb > core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 78cd257 > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 2765474 > core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java > 801bfe6 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java > 36ad1df > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > 2aed936 > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 8e2453e > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 65996d9 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 9609fdc > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > c36a675 > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 581d3b3 > core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 8b2dc16 > core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > b9ffa7a > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 8e8d7d3 > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 6cee32a > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > dd9e1c9 > core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java > fb021bd > core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java > 1257640 > core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java > 94bafa5 > core/src/main/java/org/apache/oozie/command/ResumeTransitionXCommand.java > 0e40dc1 > core/src/main/java/org/apache/oozie/command/SuspendTransitionXCommand.java > d64e55f > core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 6024138 > core/src/main/java/org/apache/oozie/command/XCommand.java bdf13f6 > core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java > e0ccd0f > > core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 650e7f8 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java > d4c98c8 > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 0af7edc > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > fcc86a8 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > f6c1782 > > core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 6d8aa0f > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 969336d > core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > cae9591 > core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java > 0b4045a > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > edfac48 > core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 836e5d4 > core/src/main/java/org/apache/oozie/command/wf/BulkWorkflowXCommand.java > 4e0b606 > core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 178eaf4 > core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 3e2996f > core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java ef97990 > core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > bc80dfe > core/src/main/java/org/apache/oozie/compression/CodecFactory.java 72cf385 > core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 809c026 > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 82f9bed > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java 9475f72 > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java > 504bc3d > > core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorPhaseOne.java > 6525125 > > core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorUtil.java > 653fb2a > core/src/main/java/org/apache/oozie/dependency/DependencyChecker.java > bdd854f > core/src/main/java/org/apache/oozie/dependency/URIHandler.java da68b00 > > core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java > a5a31e4 > core/src/main/java/org/apache/oozie/event/EventQueue.java 67fb0f9 > core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > e98d10a > core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > 09b110e > core/src/main/java/org/apache/oozie/event/messaging/MessageSerializer.java > f480ddb > > core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java > 92b37f8 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsDeleteJPAExecutor.java > c651d85 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java > 02a4f68 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsDeleteJPAExecutor.java > 8dd20cc > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsDeleteJPAExecutor.java > cbebef3 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java > 6d13ed1 > > core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java > c2e246a > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionDeleteJPAExecutor.java > 14dc45d > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java > 51449db > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java > 6647a99 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java > 43c7d08 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsDeleteJPAExecutor.java > 8674aa2 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java > 13af8f8 > core/src/main/java/org/apache/oozie/jms/ConnectionContext.java 6794569 > core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java 75751eb > core/src/main/java/org/apache/oozie/service/AuthorizationService.java > 4e4ab17 > core/src/main/java/org/apache/oozie/service/CallableQueueService.java > a86a8d0 > core/src/main/java/org/apache/oozie/service/ELService.java d27d47f > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 5377127 > core/src/main/java/org/apache/oozie/service/JMSTopicService.java 35c82c3 > core/src/main/java/org/apache/oozie/service/JPAService.java 028381d > > core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java > b57a2a5 > core/src/main/java/org/apache/oozie/service/ProxyUserService.java 39b5774 > core/src/main/java/org/apache/oozie/service/SLAStoreService.java 02899cc > core/src/main/java/org/apache/oozie/service/SchedulerService.java 81fbc0d > core/src/main/java/org/apache/oozie/service/SchemaService.java 3181495 > core/src/main/java/org/apache/oozie/service/Services.java 829d5f5 > core/src/main/java/org/apache/oozie/service/StoreService.java 7868e02 > core/src/main/java/org/apache/oozie/service/URIHandlerService.java c4a3701 > core/src/main/java/org/apache/oozie/service/UUIDService.java 313f9dd > core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 6891bbe > core/src/main/java/org/apache/oozie/service/WorkflowStoreService.java > 72e0fe4 > core/src/main/java/org/apache/oozie/service/XLogService.java 04f04f4 > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > a64f613 > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 64d3f1f > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 2110522 > core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java 8dfd160 > core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java a7b0921 > core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java 2c79ef0 > core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java 965a19a > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 60f1029 > core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 80c8ec4 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 662a7ff > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 3a76dfe > core/src/main/java/org/apache/oozie/sla/SLACalculator.java 146cdcb > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3522ffe > core/src/main/java/org/apache/oozie/sla/SLAOperations.java 3905003 > core/src/main/java/org/apache/oozie/sla/listener/SLAEventListener.java > ab77104 > core/src/main/java/org/apache/oozie/store/OozieSchema.java 23dd1e5 > core/src/main/java/org/apache/oozie/store/SLAStore.java 34f47fb > core/src/main/java/org/apache/oozie/store/Store.java b60f022 > core/src/main/java/org/apache/oozie/store/WorkflowStore.java c565e74 > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 1c565ef > core/src/main/java/org/apache/oozie/util/DateUtils.java 3caf0a2 > core/src/main/java/org/apache/oozie/util/ELEvaluator.java 84eaa3d > core/src/main/java/org/apache/oozie/util/GraphGenerator.java 6ded2c6 > core/src/main/java/org/apache/oozie/util/JaasConfiguration.java cb9dd17 > core/src/main/java/org/apache/oozie/util/JobUtils.java a7a53b3 > core/src/main/java/org/apache/oozie/util/MappingRule.java 312ec13 > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > 9d69f74 > core/src/main/java/org/apache/oozie/util/ParamChecker.java 8debeef > core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java > 7228620 > core/src/main/java/org/apache/oozie/util/PropertiesUtils.java 3e24e00 > > core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > 78cb042 > core/src/main/java/org/apache/oozie/util/StatusUtils.java 24eba21 > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > a676f4d > core/src/main/java/org/apache/oozie/util/WritableUtils.java aa027e3 > core/src/main/java/org/apache/oozie/util/XCallable.java 2c034a4 > core/src/main/java/org/apache/oozie/util/XLog.java cc9abd8 > core/src/main/java/org/apache/oozie/util/XLogFilter.java 3b49f77 > core/src/main/java/org/apache/oozie/util/XLogStreamer.java 19f1fee > core/src/main/java/org/apache/oozie/util/XLogUserFilterParam.java 1fe59e3 > core/src/main/java/org/apache/oozie/util/XmlUtils.java f850236 > core/src/main/java/org/apache/oozie/util/ZKUtils.java 8069641 > core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java 285827d > core/src/main/java/org/apache/oozie/util/db/Schema.java 0ba09fc > core/src/main/java/org/apache/oozie/util/db/SqlStatement.java b739da5 > core/src/main/java/org/apache/oozie/workflow/WorkflowInstance.java 9313642 > core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java > 3c41c83 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > a74e5c7 > pom.xml 551a622 > server/src/main/java/org/apache/oozie/server/EmbeddedOozieServer.java > b7918b7 > server/src/main/java/org/apache/oozie/server/JspHandler.java 9658fd6 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java 8ec3fae > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java > 30d68e2 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > 785ca5e > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandler.java > ec6ee00 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java > 82c5f40 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieActionConfigurator.java > c2a100e > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/OozieLauncherOutputCommitter.java > 84c09bb > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java > f109318 > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 87c4cc4 > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java > 0da74d4 > tools/src/main/java/org/apache/oozie/tools/OozieDBExportCLI.java ba74ef1 > tools/src/main/java/org/apache/oozie/tools/OozieDBImportCLI.java 0e14a30 > > Diff: https://reviews.apache.org/r/53878/diff/ > > > Testing > ------- > > Java doc changes only. > > > Thanks, > > Abhishek Bafna > >
