[
https://issues.apache.org/jira/browse/OOZIE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726658#comment-15726658
]
Hadoop QA commented on OOZIE-2422:
----------------------------------
Testing JIRA OOZIE-2422
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [examples].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1831
. Tests failed: 7
. Tests errors: 4
. The patch failed the following testcases:
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
.
testBundleStatusTransitWithLock(org.apache.oozie.service.TestStatusTransitService)
.
testActionKillCommandDate(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)
. Tests failing with errors:
. testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)
. testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
. testShareLibLoadFile(org.apache.oozie.service.TestShareLibService)
. testLoadDump(org.apache.oozie.tools.TestDBLoadDump)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3491/
> Recovery service loads jobs which doesn't need recovery
> -------------------------------------------------------
>
> Key: OOZIE-2422
> URL: https://issues.apache.org/jira/browse/OOZIE-2422
> Project: Oozie
> Issue Type: Bug
> Reporter: Purshotam Shah
> Assignee: Satish Subhashrao Saley
> Attachments: OOZIE-2422-1.patch
>
>
> {code}
> @NamedQuery(name = "GET_COORD_ACTIONS_FOR_RECOVERY_OLDER_THAN", query
> = "select a.id, a.jobId, a.statusStr, a.externalId, a.pending from
> CoordinatorActionBean a where a.pending > 0 AND (a.statusStr = 'SUSPENDED' OR
> a.statusStr = 'KILLED' OR a.statusStr = 'RUNNING') AND
> a.lastModifiedTimestamp <= :lastModifiedTime"),
> {code}
> Recovery service use above sql to recover killed/suspended/running action and
> in code it checks for external id. Checking of externalId can be done in sql
> itself.
> {code}
> else if (caction.getStatus() == CoordinatorActionBean.Status.SUSPENDED) {
> if (caction.getExternalId() != null &&
> caction.getPending() > 1) {
> queueCallable(new
> SuspendXCommand(caction.getExternalId()));
> log.debug("Recover a SUSPENDED coord action
> and resubmit SuspendXCommand :"
> + caction.getId());
> }
> }
> else if (caction.getStatus() ==
> CoordinatorActionBean.Status.KILLED) {
> if (caction.getExternalId() != null) {
> queueCallable(new
> KillXCommand(caction.getExternalId()));
> log.debug("Recover a KILLED coord action and
> resubmit KillXCommand :" + caction.getId());
> }
> }
> else if (caction.getStatus() ==
> CoordinatorActionBean.Status.RUNNING) {
> if (caction.getExternalId() != null) {
> queueCallable(new
> ResumeXCommand(caction.getExternalId()));
> log.debug("Recover a RUNNING coord action and
> resubmit ResumeXCommand :" + caction.getId());
> }
> }
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
