----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54705/#review160656 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/client/XOozieClient.java (line 119) <https://reviews.apache.org/r/54705/#comment231818> "ResourceManager is not specified in conf" core/src/main/java/org/apache/oozie/WorkflowJobBean.java (line 607) <https://reviews.apache.org/r/54705/#comment231819> I was looking at http://stackoverflow.com/questions/933447/how-do-you-cast-a-list-of-supertypes-to-a-list-of-subtypes. This still generics an unchecked warning, so is there an advantage to this ugly double casting vs just doing ````(List)````? core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 250) <https://reviews.apache.org/r/54705/#comment231821> This should be changed to use ````Configuration````. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 253) <https://reviews.apache.org/r/54705/#comment231820> ````JobConf```` is an MR thing. We should use a ````Configuration```` core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 254) <https://reviews.apache.org/r/54705/#comment231822> ? core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (lines 262 - 266) <https://reviews.apache.org/r/54705/#comment231823> We'll probably need to change the ````OozieActionConfigurator```` interface to use a ````Configuration```` object instead of a ````JobConf```` object. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/54705/#comment231824> Yay!!! core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (lines 991 - 1001) <https://reviews.apache.org/r/54705/#comment231825> Instead of doing this (which I know is equivalent to what we currently do), would it better to call ````check(...)```` instead? I think it handles stuff better (e.g. fallback to data file, etc). Or maybe we can extract out the common code into a new method and have them both call that, if we don't want all of ````check(...)```` here. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (lines 1113 - 1117) <https://reviews.apache.org/r/54705/#comment231827> Do we need this? core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 1115) <https://reviews.apache.org/r/54705/#comment231828> Does this mean the launcher logs can't be larger than 1GB? core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 1341) <https://reviews.apache.org/r/54705/#comment231830> Do we still need this method? We have ````createYarnClient```` now. core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 1396) <https://reviews.apache.org/r/54705/#comment231833> We should try to replace this with ````Configuration```` core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java (line 1538) <https://reviews.apache.org/r/54705/#comment231836> Let's give a more helpful message here. core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java (line 148) <https://reviews.apache.org/r/54705/#comment231837> I don't think we need this anymore? Probably not for a long time. core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java (lines 156 - 158) <https://reviews.apache.org/r/54705/#comment231843> We shouldn't need the MR jars in the Spark Action :) core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java (line 48) <https://reviews.apache.org/r/54705/#comment231846> This isn't deprecated, is it? core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java (line 538) <https://reviews.apache.org/r/54705/#comment231847> (I think I originally wrote this Javadoc but,) I think we should add an additional sentence: Return a YarnClient created with the provided user and configuration. The caller is responsible for closing it when done. core/src/main/resources/oozie-log4j.properties (line 35) <https://reviews.apache.org/r/54705/#comment231855> This is the issue we discussed in today's meeting about the logger breaking things, right? In any case, I don't think we want to get rid of this. core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (lines 268 - 269) <https://reviews.apache.org/r/54705/#comment231857> ? core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java (lines 1640 - 1674) <https://reviews.apache.org/r/54705/#comment231858> What's the plan here? core/src/test/java/org/apache/oozie/client/TestOozieCLI.java (lines 137 - 138) <https://reviews.apache.org/r/54705/#comment231859> 9000 and 9001 are super old default ports. Let's take this opportunity to update them to 8020 and 8032 here and elsewhere. core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java (line 23) <https://reviews.apache.org/r/54705/#comment231860> No * imports please distro/src/main/bin/addtowar.sh (line 98) <https://reviews.apache.org/r/54705/#comment231862> This is probably the same for Hadoop 3 as well. docs/src/site/twiki/DG_QuickStart.twiki (line 44) <https://reviews.apache.org/r/54705/#comment231863> This was changed to 2.6.0 in the pom docs/src/site/twiki/DG_QuickStart.twiki (lines 45 - 46) <https://reviews.apache.org/r/54705/#comment231864> Are these still separate? If so, there's no reason to split these from ````hadoop.version```` anymore now that Hadoop 1 is gone. docs/src/site/twiki/DG_QuickStart.twiki (line 47) <https://reviews.apache.org/r/54705/#comment231865> 0.12.1 < 0.16.0, right? docs/src/site/twiki/ENG_Building.twiki (line 117) <https://reviews.apache.org/r/54705/#comment231866> 2.6.0 docs/src/site/twiki/ENG_Building.twiki (line 215) <https://reviews.apache.org/r/54705/#comment231867> 2.6.0 docs/src/site/twiki/ENG_Building.twiki (lines 216 - 217) <https://reviews.apache.org/r/54705/#comment231868> Same comment as in DG_QuickStart docs/src/site/twiki/ENG_Building.twiki (line 219) <https://reviews.apache.org/r/54705/#comment231869> h2 findbugs-filter.xml (line 18) <https://reviews.apache.org/r/54705/#comment231810> I'm fine with ignoring some findbugs stuff (Hadoop has a ton of these), but I think we should add a comment for each exclusion explaining it. As it stands, I only know the class and findbugs pattern name. It would be nice to at least narrow it down to the method and a reason why we can exclude it. hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java (line 22) <https://reviews.apache.org/r/54705/#comment231872> Why do we need a factory for this? Creating one seems pretty straightforward. pom.xml (line 1949) <https://reviews.apache.org/r/54705/#comment231817> The wfgen profile was removed; we shouldn't add it back. pom.xml (line 1950) <https://reviews.apache.org/r/54705/#comment231816> I'm not sure if it's easier to do it separately or not, but I had created OOZIE-2761 to drop Hadoop 1 from trunk. It is also supposed to change the project version from 4.4.0-SNAPSHOT to 5.0.0-SNAPSHOT. I'm fine with doing the changes here, but if we do them in OOZIE-2761, it would remove some of the changes here, making this patch smaller (i.e. hadooplibs, etc) sharelib/hive2/src/main/java/org/apache/oozie/action/hadoop/Hive2Main.java (line 265) <https://reviews.apache.org/r/54705/#comment231873> I'm not sure we need to print the security manager here sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java (lines 63 - 64) <https://reviews.apache.org/r/54705/#comment231874> We're on Java 7 now so you can use try-with-resources sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java (lines 105 - 107) <https://reviews.apache.org/r/54705/#comment231875> try-with-resources sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java (lines 118 - 127) <https://reviews.apache.org/r/54705/#comment231876> try-with-resources sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java (lines 51 - 54) <https://reviews.apache.org/r/54705/#comment231892> From what I can tell, they're just for a message when LocalFsOperations#getLocalFileContentAsString throws an Exception. I think we can just use their counterparts that are used for the key in the map. i.e. ACTION_DATA_NEW_ID instead of ACTIONOUTPUTTYPE_ID_SWAP, etc No reason to essentially duplicate all of these. Also, there's only two files we pass to getLocalFileContentAsString: action-data.seq, which has most things, and externalChildIDs, which has the external child IDs. The Exception is thrown if we have too much data, but the message says it's for each of these file types, which is not true because there's only 2 files and 4 of these types. sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java (line 157) <https://reviews.apache.org/r/54705/#comment231891> launcherExecutedProperly sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java (lines 154 - 159) <https://reviews.apache.org/r/54705/#comment231894> Can be simplified with a multi-catch (or whatever it's called). http://docs.oracle.com/javase/7/docs/technotes/guides/language/catch-multiple.html sharelib/spark/pom.xml (line 254) <https://reviews.apache.org/r/54705/#comment231895> ${spark.scala.binary.version} sharelib/spark/pom.xml (lines 375 - 393) <https://reviews.apache.org/r/54705/#comment231896> I don't think we need this anymore (the other actions certainly don't need it) - Robert Kanter On Jan. 5, 2017, 1:16 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54705/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 1:16 p.m.) > > > Review request for oozie, Purshotam Shah, Robert Kanter, and Rohini > Palaniswamy. > > > Repository: oozie-git > > > Description > ------- > > Replacing the launcher MR job with a launcher AM > > > Diffs > ----- > > client/pom.xml f99366c90887a5a45f3942291c90e1cdbfd84b3f > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > e67fae9e2c7b32c1f209c24b4aba98daba96c06e > client/src/main/java/org/apache/oozie/client/XOozieClient.java > 8538ec7c742cc013f7c18eaff3ecf61c2835cc8a > core/pom.xml 1dd104581ccab7976d788b674d2200e48a70c27f > core/src/main/java/org/apache/oozie/WorkflowJobBean.java > 55d79a5d5e5e4efab9eb832e9341a16bcf8959cc > core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1d6456b236bf9e27c0f55d9f9e3b4bd94517c797 > core/src/main/java/org/apache/oozie/action/hadoop/Credentials.java > eadb47b07d157f45f086517ab41c4b9826f003f0 > core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProvider.java > 6fe22fbd2fca5d873d58ece60f20d0f131371475 > core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 78cd257a836707c1efeac13566d6285d42970545 > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 27654741101d2056b25626fbbe345183eafd612d > core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java > 801bfe6eb212b549888f0e9fb7df7b65bcf59393 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java > 36ad1df727e869b8051481ad969771e91bc6ae07 > core/src/main/java/org/apache/oozie/action/hadoop/HadoopELFunctions.java > ad2a71d641caa71efc098ad00bfbab3cec4d9506 > core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java > 307f565786ad77f5a35b5790bd5b052b04c6eac8 > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > 2aed936af75da38c433be5d202bdc01c2f612c76 > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 8e2453ef4f78f4a5f1f95b1ca2793f5d7e07ad81 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 4beeb965a461e246479c3e8ad88f92ecafca13c1 > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 9609fdc2f3440fb176b659ef16c2a23451724cf9 > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 55c937249ac35e14bd63dd0c1fa962ea636afa3a > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java > 581d3b3219eff882f961c8e495611e873c6a5a52 > core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 8b2dc16db80ad602911f1f64e60cfad41b198922 > > core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java > f2541265ca71fb7f3b053c59775ef5e23d0d8f94 > core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > b9ffa7ab7ec87db8a76a3653c74974d296c8cd17 > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 8e8d7d308b294efd91e3057e0d88ee06643ab2d4 > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 6cee32aa8f5b8b36c9c7a98bb738f50b18b64624 > core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java > fb021bd022d199f93fc5674843514abf45ae12a5 > core/src/main/java/org/apache/oozie/command/XCommand.java > bdf13f65ea25e8e0f5125e2798568a2c03fffe81 > core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java > d2a2742ae418070a1cd0a889f14194224bc944a6 > core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java > cc61d3de813c75c7f1cf4d405fc043253e3ca4ea > > core/src/main/java/org/apache/oozie/command/wf/SubmitScriptLanguageXCommand.java > 9d413059e99bc676feb63e02a2f704048eb4a355 > core/src/main/java/org/apache/oozie/command/wf/SubmitSqoopXCommand.java > 51b739e21c802e09f4110b740138f4ff5c341fe4 > > core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java > 0da60ec70373399414a637c22753da7e2a7e6618 > > core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java > 3bc467535202e13387b1d29ac678573f4154c522 > core/src/main/java/org/apache/oozie/service/CallableQueueService.java > a86a8d0889138cd1564ca9253e5b319ea52e55cc > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 22c6fb0965f45c5cf2322c251d4a8aa77d263458 > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 5377127736cf189bcf4aa3d62bbbeab6b3a29d52 > core/src/main/java/org/apache/oozie/service/Services.java > 829d5f5cd90c86e6cba9854dc0b4b7df570b8900 > core/src/main/java/org/apache/oozie/service/ShareLibService.java > b79bd37bb2b44348f220128334497d788dd922d4 > core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java > 612302173e0f485345558b0c96a8a75d2f43d238 > core/src/main/java/org/apache/oozie/store/OozieSchema.java > 23dd1e508b6c721a10c9fe828baa5cd0d95064b4 > core/src/main/java/org/apache/oozie/util/ClasspathUtils.java PRE-CREATION > core/src/main/java/org/apache/oozie/util/IOUtils.java > a6c2fdae049d1df936a0345f5ffc6609ea40a5c0 > core/src/main/java/org/apache/oozie/util/Instrumentation.java > 55e00d4dfc1009b6724918a328e254228a2f6240 > core/src/main/java/org/apache/oozie/util/JobUtils.java > a7a53b355d194b55959ede20c85d38e02294853d > core/src/main/resources/META-INF/persistence.xml > edda2d5e22856b0250a53bfde7c73fd96f85c6e9 > core/src/main/resources/oozie-default.xml > 2d7650acee73af713e2e3ea70975e74d1866cfd4 > core/src/main/resources/oozie-log4j.properties > c86b30143f5f58135493d9e6bdba29f402a0b1fd > core/src/test/java/org/apache/oozie/QueryServlet.java PRE-CREATION > core/src/test/java/org/apache/oozie/action/hadoop/BlockingMapper.java > PRE-CREATION > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 4baed6e42beccd2fdb55ab1e6fb150c0d8821a9c > core/src/test/java/org/apache/oozie/action/hadoop/MapperReducerForTest.java > 8f08ddd9fa077fc9526814fd25e7477850c51737 > > core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > e8a140f330062c5ce8324112aae83b3d0ae1f772 > core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java > b27ede7fae8297d982a5dee612fe714cf61f673e > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 8965cdff8627cb2ae0d2b167d7e48eab9b7825c8 > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > aa938d01b7273d6db273908e5480b71613598135 > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 4cda6151ca5bb0d9007f11bfe712de74b1a0da26 > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java > 5bc7d00ff6c6c2d29806633761cba4a940ce512a > > core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java > df9e939cb236e8b65e7b3aa9ab683c33f5fa02b7 > > core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1531ed994740d8d509c5429f761f4aa2e83c3227 > core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java > e757e542cb6256906f43a36f7d30c8e8b8aa04e2 > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > ce95ff34030c97b56ed9257ebe027833493a9fa1 > core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java > 51ae9e87d060c9e276ca74b45b24a5f5ae65e722 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 8034bbe9e6caa1672a0018daf48d649c5e5d2410 > core/src/test/java/org/apache/oozie/command/wf/HangServlet.java > 3344cf97762c77f5660d94341e72df4243f76eb2 > core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java > 5898d1af79631a1b7e5021d9ca05685eab7225a5 > core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > ea90c087fc145650dfb77ac35a03ba1203ffb0f2 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitHiveXCommand.java > 43edf5efad0932aa5089ac8a6f6cfcf9f120d966 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java > 5bc5747786774766e7156cb241d5444fefe6d7cb > core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java > 5a1de25c85129e0b9567d0fd045133bffc700c5d > core/src/test/java/org/apache/oozie/command/wf/TestSubmitSqoopXCommand.java > 49b5028bcaff62e752a9582f1ddb5fb2ec56433c > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java > 72f01148ea457085f293689eda30509a1ca694d6 > core/src/test/java/org/apache/oozie/service/TestConfigurationService.java > f18a8c073d280b9570f815be30d72c5b349ca7f5 > core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java > bbca4794b693f865290adaa915d60019fc1218dd > core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 8fd0c2d5080b416470a8d886f69c7e3de8fa3ffc > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > 2d31f9a86c25c15ee50bd420fb7300ee81a20835 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java > ea778bd19f272876f1f8d38614ecba47649526ef > core/src/test/java/org/apache/oozie/test/XFsTestCase.java > 1d399e4ce921af8cb2cb2e6375d425dd5f7780f7 > core/src/test/java/org/apache/oozie/test/XTestCase.java > e1d9068f3ae0ee2ee01eb1e8f6e7164fd3c865b8 > core/src/test/java/org/apache/oozie/util/TestClasspathUtils.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > a3c7b142d08101e2bb03737871db939133bd3cd2 > distro/src/main/bin/addtowar.sh 399040936bde3d091d42557f6a64a0aee2b139e2 > docs/src/site/twiki/DG_QuickStart.twiki > 2b9dc3bc753e7bf712117a92b76cdf29d11446cc > docs/src/site/twiki/ENG_Building.twiki > dda829b7eb9c1683f5999e436dafaa531be0920a > findbugs-filter.xml PRE-CREATION > hadooplibs/hadoop-auth-1/pom.xml 85e2298c25fc13bfc29ef8e0226d4eda2a95a073 > hadooplibs/hadoop-auth-2/pom.xml 7202b2e036bb49964435d089d9f9ff1e9237a7f7 > hadooplibs/hadoop-distcp-1/pom.xml bbc536b5901540e8f0835f75e185b7bb40e02e3c > hadooplibs/hadoop-distcp-2/pom.xml 2c21b12068ecc9782e2d12c4376ee16bfba16af0 > hadooplibs/hadoop-distcp-3/pom.xml 39cf9f26c71dc5a93bceb1f750de46002d2c7f80 > hadooplibs/hadoop-utils-1/pom.xml a53e9bca3024d924b7e9e79f2199d30b18506132 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > c0a237777f44e4d0a9061fc468af98cec2b92aa9 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > 799dffbd7dc04654e72fa8de484143732f725fa1 > hadooplibs/hadoop-utils-2/pom.xml 7c4a0a10a56a79ce0513bfa2f790ffbbc5eb960a > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > a0b7d62c9432614f33baa3631660e6cb7918cd94 > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > c21884c7f94dab78be4a6dea20b698476479dc17 > hadooplibs/hadoop-utils-3/pom.xml 2f36f8bea921ad5ff74663728b377352daf0b2ca > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > 0cf2e909283712f6e93653241f62ba601ae85706 > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > c21884c7f94dab78be4a6dea20b698476479dc17 > hadooplibs/pom.xml 06801cc6d8dcfe1fa21367c3bb26c3f8dcaf29ec > pom.xml 0cb5c7888d0cc534f7245b1d183228c3feacc377 > sharelib/distcp/pom.xml 1f3c0cc6da4e996045fcce39e0e6477df2589f63 > > sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java > 2b84f92ce0f7028e4a7f8d1b520b9dfcee6a83bd > sharelib/hcatalog/pom.xml 6eb88ef85e2f8c9398df64908e7777f251c1dbfa > sharelib/hive/pom.xml 13312192b634be802b3bc52726770d5c7b4057e9 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > bbcaefa2b363fcf8dd7ce481fc7db71fda69bdad > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 12e1e91cf83a109d77b6a20b022dee851447525d > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > 302631182a3e70f7188272d1260c2a393b283d31 > sharelib/hive2/pom.xml e81bfbe0a96a490b349a2660a0b00381d56785e1 > sharelib/hive2/src/main/java/org/apache/oozie/action/hadoop/Hive2Main.java > 54f703926e360e1942f4da41d712c29c02a3332a > > sharelib/hive2/src/test/java/org/apache/oozie/action/hadoop/TestHive2ActionExecutor.java > 4818bb6399a6c9d315af8fee7667db3691704840 > sharelib/oozie/pom.xml 4a89934f73012a89f9e56b791352bdeec4bafded > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMCallBackHandler.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMClientAsyncFactory.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ActionUtils.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ErrorHolder.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java > 30d68e2a55dd2e6b695c27ec18e5e47a48eb9322 > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAMCallbackNotifier.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > 785ca5ea2fdaef3b414bd96c6872035b7a10c680 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 7271486646edabab19066a0a6986398f12691516 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LocalFsOperations.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 23447cf87427af2de8623d3715696d38c429f962 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java > 21ae456b768fb1cb5334a9e23e6c6082240f8dff > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsHandler.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java > f109318d949c68d4738e65de5a63de7c950a7888 > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/LauncherAMTestMainClass.java > PRE-CREATION > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestHdfsOperations.java > PRE-CREATION > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAM.java > PRE-CREATION > sharelib/pig/pom.xml 233873c87091adef31bd0f40ecdb18b757c8d0f5 > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 87c4cc4cca2d2d299b814a82c108d87574bc6946 > > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java > b84e2b5ee37df078e48959584eb41ec1a90200ca > > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 25092ce55d8407384837b07d6d58b0218d1de7ab > > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMainWithOldAPI.java > e52e6fddd474da1bd3c4b03376b7b060df2ab3b5 > sharelib/spark/pom.xml abef24fe7f8a95f35347c2515385f9f582864559 > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java > 0da74d4ac55710a541eb28ee0ac8ab36bfd4fa00 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestPyspark.java > 458baaa8b6f5bc4ec5dd8395d428a7e4215fb27c > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > 8c77be0bdd7bf8cae07c4d4acd803df5730826e7 > sharelib/sqoop/pom.xml d5afa370b19ac3895e99c4bf594d3d32a4711d5b > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > cb65eb82077b6ab4a08f25866386435fcb0b107c > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 166d939b6016aa0f8a1739adc2ea17aed0b7ee7b > sharelib/streaming/pom.xml 4f732724846411f13bd0204cdc2bef198b44f0c6 > > sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java > 991bf7e849171cb7847fa6d64781ceb0782dae7c > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > c7860bed2ee46d88a9ce7768b5d2c4d6cabc3094 > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > 9aa4cb6bf47a632b87b187882a8e105c40f38daf > webapp/pom.xml 2c4dfc263f90c2167ff76aac1297ceb19cd32ae9 > > Diff: https://reviews.apache.org/r/54705/diff/ > > > Testing > ------- > > Junit tests are passing. > Submitted jobs to a hadoop cluster successfully. > > > Thanks, > > Peter Cseh > >
