----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55214/#review162319 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 182) <https://reviews.apache.org/r/55214/#comment233648> missingdeps instead of missingDependencies. Too long and we don't use camel case for command line options. client/src/main/java/org/apache/oozie/cli/OozieCLI.java (line 386) <https://reviews.apache.org/r/55214/#comment233651> List missing dependencies of a coord action. To specify multiple actions, use with -action or -date option. client/src/main/java/org/apache/oozie/client/OozieClient.java (line 595) <https://reviews.apache.org/r/55214/#comment233655> Can you move this utility method to either bottom of the class or next to where it is called? client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1223) <https://reviews.apache.org/r/55214/#comment233656> Get coord action missing dependencies client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1235) <https://reviews.apache.org/r/55214/#comment233657> Get coord action missing dependencies client/src/main/java/org/apache/oozie/client/OozieClient.java (lines 1267 - 1274) <https://reviews.apache.org/r/55214/#comment233658> You should send it in sorted order. Users consuming webservice should not have to do this. client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1277) <https://reviews.apache.org/r/55214/#comment233649> Command line output uses camel casing and is not consistent with other outputs. For eg: job -info. In general, avoid camel casing in user facing options, output or documentation. Please change command line output from id : 6 blockedOn : hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS dataSet : input-1 missingDependencies : hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/40/_SUCCESS hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/20/_SUCCESS to below. "CoordAction ID" already exists and is used in other job command outputs. CoordAction ID : 6 Blocked on : hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS Dataset : input-1 Pending Dependencies : hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/06/00/_SUCCESS hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/40/_SUCCESS hdfs://localhost:9000/user/purushah/examples/input-data/rawLogs/2010/01/01/05/20/_SUCCESS client/src/main/java/org/apache/oozie/client/OozieClient.java (line 1312) <https://reviews.apache.org/r/55214/#comment233660> No missing input dependencies found client/src/main/java/org/apache/oozie/client/rest/JsonTags.java (lines 248 - 249) <https://reviews.apache.org/r/55214/#comment233661> Indentation does not look right. core/src/main/java/org/apache/oozie/CoordinatorEngine.java (line 990) <https://reviews.apache.org/r/55214/#comment233663> Get coord action missing dependencies core/src/main/java/org/apache/oozie/CoordinatorEngine.java (line 994) <https://reviews.apache.org/r/55214/#comment233664> ... list of missing input dependencies. Avoid capitalizing in the middle of sentence unless required. core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java (line 48) <https://reviews.apache.org/r/55214/#comment233668> CoordActionMissingDependenciesXCommand core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java (lines 123 - 129) <https://reviews.apache.org/r/55214/#comment233669> Instead of creating a new one and copying over both, can do pullDependencies.putAll(pushDependencies); core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java (lines 324 - 326) <https://reviews.apache.org/r/55214/#comment233670> I don't see CoordPushInputDependency implementing this method. How does it work for that? core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java (line 66) <https://reviews.apache.org/r/55214/#comment233671> GET_COORD_ACTION_DEPENDENCIES core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java (line 53) <https://reviews.apache.org/r/55214/#comment233672> Declared but not used core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java (line 332) <https://reviews.apache.org/r/55214/#comment233674> Use COORDINATOR_ACTION_ID instead. Same but reads better in context. core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java (line 63) <https://reviews.apache.org/r/55214/#comment233675> testCoordActionPullDependencyMissing core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java (line 117) <https://reviews.apache.org/r/55214/#comment233676> testCoordActionPushDependencyMissing core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java (line 172) <https://reviews.apache.org/r/55214/#comment233677> testCoordActionPullPushDependencyMissing docs/src/site/twiki/DG_CommandLineTool.twiki (line 973) <https://reviews.apache.org/r/55214/#comment233678> Getting missing dependencies of coordinator action(s) docs/src/site/twiki/DG_CommandLineTool.twiki (lines 974 - 975) <https://reviews.apache.org/r/55214/#comment233686> Coordination action id can be specified directly as coordjobid@actionid for getting information on a single action. To get information on multiple actions, either -action or -date option can be specified with the coordinator job id. docs/src/site/twiki/DG_CommandLineTool.twiki (line 976) <https://reviews.apache.org/r/55214/#comment233687> The -missingdeps command doesn't recompute dependencies. It lists missing dependencies which were last computed. docs/src/site/twiki/DG_CommandLineTool.twiki (line 977) <https://reviews.apache.org/r/55214/#comment233688> =blockedOn= -> Blocked on docs/src/site/twiki/DG_CommandLineTool.twiki (line 978) <https://reviews.apache.org/r/55214/#comment233689> missingDependencies command -> the command which missing -> which is missing docs/src/site/twiki/WebServicesAPI.twiki (line 1588) <https://reviews.apache.org/r/55214/#comment233690> Getting missing dependencies of coordinator action(s) webapp/src/main/webapp/oozie-console.js (lines 1529 - 1531) <https://reviews.apache.org/r/55214/#comment233691> missingDependencies is an array. Fix the response to always be in order instead of sorting here. This is same as the comment in OozieClient. - Rohini Palaniswamy On Jan. 6, 2017, 10:33 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55214/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 10:33 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2770 > https://issues.apache.org/jira/browse/OOZIE-2770 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2770 Show missing dependencies for coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > e67fae9e2c7b32c1f209c24b4aba98daba96c06e > client/src/main/java/org/apache/oozie/client/OozieClient.java > 12c80cbf422447c8d5c98e6ba95737e127087173 > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 397e9ede8ebf63281c7f56f9cb9ee44c1518a1ed > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 41293642b06743294e4a640a2c66865b4e64eebd > core/src/main/java/org/apache/oozie/CoordinatorEngine.java > 91fe5a1d709ba1a90e493d301030465aa35ca790 > core/src/main/java/org/apache/oozie/ErrorCode.java > 8fc3835023744ae7506b849ee676b0f763ed575d > > core/src/main/java/org/apache/oozie/command/coord/CoordActionMissingDependenciesXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 0af7edc9094aaf24a6636ccebea17493e457fcce > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsXCommand.java > b8affd67a412fac7d4ec452d7e2efa02c62ce25a > core/src/main/java/org/apache/oozie/coord/CoordUtils.java > 82f9bede0878b361ffb47d865036573b15448c68 > > core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java > 0da60ec70373399414a637c22753da7e2a7e6618 > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependency.java > 504bc3d5f8c48676736cb461462677ddac400d17 > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java > aabd2bf25c99710ce0b025b6b66ae0fd0bb00abf > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordPullInputDependency.java > f20dcae0ff44d745ffbcb22bce2653d042a65122 > core/src/main/java/org/apache/oozie/dependency/ActionDependency.java > fe7a3272190718f21aa594188013fadfa9b58646 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > c0e6c198f4978744016f35dd8940db345a71f92c > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java > 21105223b1a8a819b4ec091e1a513e5751b51425 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > 86ff278e6ff3b6ad9f2e7ea1d3e87446e404d122 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 60f1029d49f78bff973bd167791cfcdaaa1af60f > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java > 662a7ff26ff802bcdb530af71b52685bad089a6c > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > ce95ff34030c97b56ed9257ebe027833493a9fa1 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMissingDependenciesXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/test/java/org/apache/oozie/coord/input/logic/TestCoordInputLogicPush.java > 6684a1fc7e8d1ed85b9e309cd163ae92f005f281 > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 0e74f2d1df67dd5d4aaccbdb66a3829f5894e751 > core/src/test/resources/coord-multiple-output-instance5.xml > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > docs/src/site/twiki/DG_CommandLineTool.twiki > 35eee40363ffb8d998df34a693ee318cf70a230f > docs/src/site/twiki/WebServicesAPI.twiki > b76e9343087a8c68825d222720543dc6d4d9f27a > webapp/src/main/webapp/oozie-console.js > 11c6940bb26c1a8318781ce62926b6e4a185e37c > > Diff: https://reviews.apache.org/r/55214/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
