[
https://issues.apache.org/jira/browse/OOZIE-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834237#comment-15834237
]
Peter Bacsko edited comment on OOZIE-2777 at 1/23/17 10:48 AM:
---------------------------------------------------------------
Minor:
1. Extract "UTF-8" constant in DataIOUtil
2. Perhaps StringSerializationUtil is a better name
3. Make DataIOUtil final + add private constructor
4. testSubmitLongXml -- don't catch the exception if it's not expected
5. {{dataOutput.writeInt(-1);}} -- {{-1}} is a magic number, pls extract it to
a constant
Do we have tests for the following cases?
1. LiteWorkflowApp -- read back string that was serialized as lists (defList >
-1, ensure backward compatibility)
2. LiteWorkflowApp -- read back string that was serialized with DataIOUtil
3. DataIOUtil -- string is less than 60k, write + read it back
4. DataIOUtil -- string is more than 60k, write + read it back
was (Author: pbacsko):
Minor:
1. Extract "UTF-8" constant in DataIOUtil
2. Perhaps StringSerializationUtil is a better name
3. Make DataIOUtil final + add private constructor
4. testSubmitLongXml -- don't catch the exception if it's not expected
5. {{dataOutput.writeInt(-1);}} -- {{-1}} is a magic number, pls extract it to
a constant
Do we have tests for the following cases?
1. LiteWorkflowApp -- read back string when defList was serialized as lists
(ensure backward compatibility)
2. LiteWorkflowApp -- read back string that was serialized with DataIOUtil
3. DataIOUtil -- string is less than 60k, write + read it back
4. DataIOUtil -- string is more than 60k, write + read it back
> Config-default.xml longer than 64k results in java.io.UTFDataFormatException
> -----------------------------------------------------------------------------
>
> Key: OOZIE-2777
> URL: https://issues.apache.org/jira/browse/OOZIE-2777
> Project: Oozie
> Issue Type: Bug
> Reporter: Peter Cseh
> Assignee: Peter Cseh
> Attachments: OOZIE-2777-1.patch, OOZIE-2777-2.patch
>
>
> OOZIE-1642 introduced a workaround for DataOutputStream's 64k limit for
> Strings.
> We've encountered the same error when a config-default.xml is larger than the
> limit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
