----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55879/#review162812 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java (line 33) <https://reviews.apache.org/r/55879/#comment234188> Is it still 60k? Not 20k? core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java (line 38) <https://reviews.apache.org/r/55879/#comment234189> Typo core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java (line 131) <https://reviews.apache.org/r/55879/#comment234190> Is this code path covered with test? core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java (line 34) <https://reviews.apache.org/r/55879/#comment234187> What about the case when the number of characters are below 20k? core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java (line 39) <https://reviews.apache.org/r/55879/#comment234186> I'd prefer a deterministic behaviour in an unit test. I think it's better to use Strings.repeat() from Guava. core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java (line 32) <https://reviews.apache.org/r/55879/#comment234185> Does it have to extend XTestCase? core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java (line 45) <https://reviews.apache.org/r/55879/#comment234191> Shouldn't be a class variable if it's used in only one method. Also, probably we should stick to a deterministic input. - Peter Bacsko On jan. 24, 2017, 1:25 du, Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55879/ > ----------------------------------------------------------- > > (Updated jan. 24, 2017, 1:25 du) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > Config-default.xml longer than 64k results in java.io.UTFDataFormatException > https://issues.apache.org/jira/browse/OOZIE-2777 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java > PRE-CREATION > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java > a06595d3b2b99dbe33ef5d55208435aaec151e1a > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java > 2b13e6701226b7236d101d738aba6b6ebbabf4e5 > core/src/main/java/org/apache/oozie/workflow/lite/NodeDef.java > 496b0086f840c0c6fc60a74bdb3dc382c4db2612 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 47ff8ca2751926bb728ea3eba5d7fe11282c3176 > core/src/test/java/org/apache/oozie/util/TestStringSerializationUtil.java > PRE-CREATION > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowApp.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > a3c7b142d08101e2bb03737871db939133bd3cd2 > > Diff: https://reviews.apache.org/r/55879/diff/ > > > Testing > ------- > > > Thanks, > > Peter Cseh > >
